Adding license to each source file #862
Conversation
|
Currently, have added license to only the source files under |
Codecov Report
@@ Coverage Diff @@
## develop #862 +/- ##
========================================
Coverage 88.38% 88.38%
========================================
Files 37 37
Lines 4298 4298
========================================
Hits 3799 3799
Misses 499 499
Continue to review full report at Codecov.
|
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
That looks alright. Great that you already checked the example. I think you can then annotate the whole package.
Could you please update the contribution guides, the changelog and the PR template with this information, too?
|
@mfeurer I shall make the changes and create a PR. |
|
I guess it would be great if for consistency we just annotate all files where possible. What do you think about that? |
|
Makes sense. I'll see where it is not possible. Especially in the rst files. |
* Fixing broken links (#864) * Adding license to each source file (#862) * Preliminary addition of license to source files * Adding license to almost every source file * add task_type to list_runs (#857) * add task_type to list_runs * length of run change * changelog * changes in progress rst * Prepare new release (#868)
What does this PR implement/fix? Explain your changes.
This is w.r.t. the JMLR guidelines requiring the license to be mentioned in each and every source file of the package.
Any other comments?
The sklearn repo was used as a reference. Random examples below:
If I understood the Submission Checklist correctly, they do not expect the package zip to contain other auxiliary files such as the rst files for documentation, testing files, examples, etc.