add task_type to list_runs #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #857 +/- ##
==========================================
Coverage ? 88.38%
==========================================
Files ? 37
Lines ? 4298
Branches ? 0
==========================================
Hits ? 3799
Misses ? 499
Partials ? 0
Continue to review full report at Codecov.
|
mfeurer
requested changes
Nov 6, 2019
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
This looks great, thanks a lot. Could you please add this to the changelog, too?
mfeurer
reviewed
Nov 6, 2019
|
|
||
| 0.10.1 | ||
| ~~~~~~ | ||
| * ADD #857: Adds task type ID to list_runs |
Collaborator
There was a problem hiding this comment.
This is actually my mistake (as I didn't update this yet), but since we made a new release, you need to put this under a new header.
mfeurer
approved these changes
Nov 6, 2019
PGijsbers
pushed a commit
that referenced
this pull request
Nov 7, 2019
* Fixing broken links (#864) * Adding license to each source file (#862) * Preliminary addition of license to source files * Adding license to almost every source file * add task_type to list_runs (#857) * add task_type to list_runs * length of run change * changelog * changes in progress rst * Prepare new release (#868)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this PR implement/fix? Explain your changes.
API call to list runs https://www.openml.org/api/v1/run/list/limit/10 - returns task type, while
python API does not.
added task type to list_runs call in python API
How should this PR be tested?
runs.list_runs(size=10)
Any other comments?