refactor: use v-for to render items in CallToAction#748
Merged
danielroe merged 5 commits intonpmx-dev:mainfrom Feb 3, 2026
Merged
refactor: use v-for to render items in CallToAction#748danielroe merged 5 commits intonpmx-dev:mainfrom
danielroe merged 5 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Why use more code when less code do trick
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CallToAction component to use a v-for loop instead of repeating markup for three social link cards, significantly reducing code duplication. The refactor transforms the socialLinks from an object to an array structure containing icon classes, translation keys, and URLs for each link.
Changes:
- Converted socialLinks from object to array with structured data including id, href, icon, and translation keys
- Replaced three repeated anchor elements with a single v-for loop
- Maintained all styling, accessibility attributes, and functionality
danielroe
approved these changes
Feb 3, 2026
danielroe
changed the title
taskylizard
pushed a commit
to taskylizard/npmx.dev
that referenced
this pull request
Feb 7, 2026
Co-authored-by: Daniel Roe <daniel@roe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why use more code when less code do trick
Draft because depends on #746