fix: use CSS subgrid to ensure alignment in CallToAction#746
Merged
danielroe merged 3 commits intonpmx-dev:mainfrom Feb 2, 2026
Merged
fix: use CSS subgrid to ensure alignment in CallToAction#746danielroe merged 3 commits intonpmx-dev:mainfrom
danielroe merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
danielroe
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes alignment issues in the CallToAction component by replacing flexbox with CSS Grid's subgrid feature. The three call-to-action cards now properly align their headers, descriptions, and action buttons across columns when viewed on larger screens.
Changes:
- Converted parent container to use CSS Grid with explicit row sizing (
auto, 1fr, auto) - Updated child cards to use
grid-rows-subgridto inherit parent grid rows and ensure vertical alignment - Applied changes only at the
smbreakpoint and above, preserving mobile layout
taskylizard
pushed a commit
to taskylizard/npmx.dev
that referenced
this pull request
Feb 7, 2026
Co-authored-by: Daniel Roe <daniel@roe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: