Conversation
wronny
approved these changes
Feb 2, 2020
Member
wronny
left a comment
wronny
left a comment
There was a problem hiding this comment.
thankfully verified on my NC18
In the introduction of the Viewer the date value was refactored to datetaken. This was not done in the photosController.js Hence the Photo loading Icon was spinning forever and the timefilter was not working for the photos. This should be fixed now. Signed-off-by: Arne Hamann <kontakt+github@arne.email>
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
tacruc
force-pushed
the
fixed-timeFilter-for-photos
branch
from
3d8261c to
fd16aac
Compare
Collaborator
Author
|
rebased to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wit the introduction of the Viewer the date value was refactored to dateTaken. This was not done in the photosController.js
Hence the Photo loading Icon was spinning forever and the timefilter was not working for the photos. This should be fixed now.
Signed-off-by: Arne Hamann kontakt+github@arne.email