Fixed update photo by file job

[tacruc]

Including allready PR #241

[tacruc]

If you change Photos in your could, the next cron job throws the errors discribed in #247.
They should be gone with this PR.

after installing i get following Error Message in Nextcloud:

[cron] Error: Error: Call to a member function getUserFolder() on null at <<closure>>

0. /var/www/nextcloud/lib/public/BackgroundJob/Job.php line 79
   OCA\Maps\BackgroundJob\UpdatePhotoByFileJob->run({fileId: 2531470,userId: "larsNC"})
1. /var/www/nextcloud/lib/public/BackgroundJob/QueuedJob.php line 48
   OCP\BackgroundJob\Job->execute(OC\BackgroundJob\JobList {}, OC\Log {})
2. /var/www/nextcloud/cron.php line 125
   OCP\BackgroundJob\QueuedJob->execute(OC\BackgroundJob\JobList {}, OC\Log {})

at 2020-01-19T06:45:10+00:00

and

[PHP] Error: Undefined property: OCA\Maps\BackgroundJob\UpdatePhotoByFileJob::$root at /var/www/nextcloud/apps/maps/lib/BackgroundJob/UpdatePhotoByFileJob.php#43

at 2020-01-19T06:30:02+00:00

i`m on Nextcloud 18.0.0, Ubuntu Server and PHP7.3-fpm with Nginx .

[Happyfeet01]

I have manually changed the files. It works, Cronjob and Maps. Also the Map loads faster.

[e-alfred]

Can confirm, after applying the changes of this PR Cron works again.

[jancborchardt]

Thanks for testing @Happyfeet01 @e-alfred! :) Would you like to be added to the Nextcloud Maps team here on Github?

[Happyfeet01]

Thanks for testing @Happyfeet01 @e-alfred! :) Would you like to be added to the Nextcloud Maps team here on Github?

Would be really nice, but I must learning coding.. :-)

[jancborchardt]

@Happyfeet01 reviewing pull requests is just as important. :)

[Happyfeet01]

Sure I do it :-)

[e-alfred]

You can add me as well to this repository.

[guillebot]

Can confirm, after applying the changes of this PR Cron works again.

Me too. Thanks guys.

[e-alfred]

This is a serious bug, so it would be good to have a new official release now on the app store so the fix is pushed to all installations out there.

[tacruc]

Its planed, see #254

[andrewdunndev]

It looks like if we wait for #254 it could be a while. This needs a release quickly as it's broken everyone's installs who uses this app. This is a "Featured" app now, breaking the entire instances background processing should be an immediate an urgent fix.

[e-alfred]

Well, if #217 is left out (optional anyways) then only a minor fix (#281) and a cosmetic issue (#253) remains which could be merged rather easily.

[guillebot]

I second that. The fixes are trivial and working, I tested them. let them roll. Thanks

…

On Fri, Feb 14, 2020 at 2:57 PM e-alfred ***@***.***> wrote: Well, if #217 <#217> is left out (optional anyways) then only a minor fix (#281 <#281>) and a cosmetic issue (#253 <#253>) remains which could be merged rather easily. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#251?email_source=notifications&email_token=AAIXVWMVAMY55LC4Z6CJ7NDRC3LQ5A5CNFSM4KJBAIB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZ4EEA#issuecomment-586400272>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIXVWILXH5OWY4OVQ5LLDLRC3LQ5ANCNFSM4KJBAIBQ> .

[lftsy]

Thank you for the fix, I confirm it is now working. Best Regards. You can close this ticket or there is something else to do ?