Fix parseIP error when parseIP before get AddressFamily

[icefed]

Signed-off-by: Tom Zhao zlwangel@gmail.com

Fix: #2431

[arkodg]

@icefed thanks for fixing this issue

thinking if something like this would be cleaner

initialize AddressFamily before the loop starts

s.AddressFamily = syscall.AF_INET

and when we receive s.AddressFamily we can recompute s.Address

                case ipvsDestAttrAddressFamily:
                       s.AddressFamily = native.Uint16(attr.Value)
                       // Recompute s.Address
                       fallthrough
		case ipvsSvcAttrAddress:
			ip, err := parseIP(attr.Value, s.AddressFamily)
			if err != nil {
				return nil, err
			}
			s.Address = ip

[arkodg]

can we also add a test case for this, so we catch it, if its 100% reproducible

[icefed]

@icefed thanks for fixing this issue

thinking if something like this would be cleaner

initialize AddressFamily before the loop starts

s.AddressFamily = syscall.AF_INET

and when we receive s.AddressFamily we can recompute s.Address

                case ipvsDestAttrAddressFamily:
                       s.AddressFamily = native.Uint16(attr.Value)
                       // Recompute s.Address
                       fallthrough
		case ipvsSvcAttrAddress:
			ip, err := parseIP(attr.Value, s.AddressFamily)
			if err != nil {
				return nil, err
			}
			s.Address = ip

Hi @arkodg, ipvsSvcAttrAddress Value has 16 bytes, we can not use ipvsDestAttrAddressFamily Value(2 bytes) to recompute Address. So, it will not work.

[arkodg]

LGTM, can we also add a test case please

[icefed]

LGTM, can we also add a test case please

Sorry for miss this, I will add test later.

[icefed]

hi @arkodg, I added tests for ipv6 and local passed, I don't know circleci: unit-tests failed.

[arkodg]

@icefed can you please rebase to the latest master, I've taken care of the unit-tests regression by reverting a commit

[thaJeztah]

@arkodg looks like this was rebased; CI is green now

[arkodg]

LGTM thanks !

[selansen]

LGTM