Skip to content

Sync dev and 2.0 branch#182

Merged
andrueastman merged 15 commits intofeature/2.0from
andrueastman/sync2.0
Dec 7, 2020
Merged

Sync dev and 2.0 branch#182
andrueastman merged 15 commits intofeature/2.0from
andrueastman/sync2.0

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Dec 7, 2020

This PR syncs changes made in the dev branch to the feature/2.0 by cherrypicking relevant commits to the dev branch since the last sync (i.e 1.20.0 release)

The relevant PRs/commits include

Exceptions

MIchaelMainer and others added 13 commits December 7, 2020 17:28
Support mac http handlers. It is important to note that Xamarin.Mac and Xamarin.iOS NSURLSessionHander are in different namespaces.
* Copy Http Content headers to the destination stream in compression handler.

* Ensure headers are not empty.

* Ensure that compressed data is the same as decompressed data.

Co-authored-by: George <gendungu@microsoft.com>
This seems to be the only implementation of a RequestBuilder which doesn't have its corresponding interface
* Fix exception thrown when not specifying slice size

* Update csproj

* Fix indentation
* Add CAE support to the core library

* Make the CAEAuthprovider class internal

* Add null check for authenticationProviderOption

Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>

Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
@andrueastman andrueastman self-assigned this Dec 7, 2020
@andrueastman andrueastman marked this pull request as ready for review December 7, 2020 16:53
@andrueastman
Copy link
Contributor Author

andrueastman commented Dec 7, 2020

@MIchaelMainer I do not intend to create a release once this PR is merged since this PR just takes the straightforward changes from dev.
I will first create a separate PR to the feature/2.0 branch(after this is merged) to handle changes mentioned in the description for #135 then create a release once that is done.

@andrueastman andrueastman merged commit 3af9403 into feature/2.0 Dec 7, 2020
@andrueastman andrueastman deleted the andrueastman/sync2.0 branch December 7, 2020 17:19
@andrueastman
Copy link
Contributor Author

andrueastman commented Dec 8, 2020

@andrueastman andrueastman linked an issue Dec 8, 2020 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync dev and 2.0 branch

3 participants