Add Continuous Access Evaluation (CAE) support#173
Merged
andrueastman merged 3 commits intodevfrom Nov 25, 2020
Merged
Conversation
andrueastman
changed the title
andrueastman
force-pushed
the
andrueastman/addCAESupport
branch
from
50341ae to
d6d2447
Compare
andrueastman
changed the title
peombwa
reviewed
Nov 23, 2020
src/Microsoft.Graph.Core/Requests/Middleware/Options/CaeAuthenticationProviderOption.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Nov 23, 2020
ddyett
reviewed
Nov 23, 2020
Contributor
ddyett
left a comment
ddyett
left a comment
There was a problem hiding this comment.
looks good to me. fine with check in once Peter's comment is addressed.
MIchaelMainer
previously approved these changes
Nov 23, 2020
Collaborator
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Approved pending suggested changes.
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
peombwa
approved these changes
Nov 24, 2020
Merged
andrueastman
pushed a commit
that referenced
this pull request
Dec 7, 2020
* Add CAE support to the core library * Make the CAEAuthprovider class internal * Add null check for authenticationProviderOption Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com> Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
This was referenced Dec 7, 2020
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #166
The PR involves extracting the claims property from WwwAuthenticate headers from 401 responses. The claims property is then Base64 decoded before being placed in the GraphContext through the
AuthenticationHandlerOptionproperty.Placing the claims in the GraphContext will then enable the relevant AuthProviders to read the claims property and use it during the Authentication phase.
Related Links