This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
503e920 to
992139a
Compare
dkbennett
approved these changes
Jan 11, 2024
vineeththomasalex
approved these changes
Jan 11, 2024
EricJohnson327
approved these changes
Jan 11, 2024
EricJohnson327
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Update pin flow * remove less-useful config template fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Accommodate the updated pin widget flow from microsoft/devhome#2110. Widgets are selected in the Add widget dialog and configured inline on the Dashboard, similar to how the Windows Widget Board does it.
References and relevant issues
Detailed description of the pull request / Additional comments
UpdateActivityState()to useoverridekeyword instead ofnew. By hiding the higher level method, the wrong one was being used. In the old flow, it happened to do the right thing, but wouldn't in the new flow.PR in Draft until we get screenshot assets.
Validation steps performed
PR checklist