This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Change Widget Pin flow to show preview images#2110
Merged
EricJohnson327 merged 3 commits intomainfrom Jan 11, 2024
Merged
Conversation
This was referenced Jan 8, 2024
dkbennett
approved these changes
Jan 11, 2024
EricJohnson327
approved these changes
Jan 11, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Change Dev Home's flow for pinning widgets to align with the Windows Widget Board. In the Add Widget dialog (aka widget picker), the user is shown widget preview images, and any configuration is done inline on the Dashboard.
References and relevant issues
Detailed description of the pull request / Additional comments
AddWidgetViewModelto show WidgetDefinition information in the Add Widget dialog.WidgetScreenshotServiceto the Dashboard, since we need to show the widget preview images ("screenshots") in the Add Widget dialog. We cache the screenshots, but only when they are going to be shown.PR in Draft while we wait for screenshot assets.
Validation steps performed
PR checklist