Merged
Conversation
Collaborator
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
Contributor
|
Thanks @Kingwl - this looks good to me |
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
May 14, 2020
* upstream/master: Perform intersection reduction before and after getApparentType (microsoft#38565) fix(33836): allow readonly modifier for a field with only get accessor (microsoft#36543) Fix build type error (microsoft#38525)
Member
|
@typescript-bot cherry-pick this into release-3.9 |
Collaborator
|
Heya @weswigham, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @weswigham, I've opened #38582 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 14, 2020
Component commits: 19624fa Fix build type error
weswigham
pushed a commit
that referenced
this pull request
May 14, 2020
Component commits: 19624fa Fix build type error Co-authored-by: kingwl <kingwenlu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Nothing but
#38518
#38522
#38523
#38526