Add deprecated related feature by Kingwl · Pull Request #38523 · microsoft/TypeScript

Kingwl · 2020-05-13T04:55:14Z

After read the codebase, I found below things need todo:

completions with symbol tag
workspace symbol with symbol tag
document symbol with symbol tag
call hierarchy with symbol tag
DiagnosticTags

current state:

Others need to do:

typescript-bot · 2020-05-13T04:55:22Z

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

Kingwl · 2020-05-13T04:55:34Z

@typescript-bot pack this.

typescript-bot · 2020-05-13T04:55:59Z

Heya @Kingwl, I've started to run the tarball bundle task on this PR at 9185734. You can monitor the build here.

Kingwl · 2020-05-13T10:30:01Z

@typescript-bot pack this.

typescript-bot · 2020-05-13T10:30:09Z

Heya @Kingwl, I've started to run the tarball bundle task on this PR at 726b933. You can monitor the build here.

typescript-bot · 2020-05-13T10:46:52Z

Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/73795/artifacts?artifactName=tgz&fileId=744B1D71C0DD25EAC199979B809F997229EB4AB80010D5B25D42E3374ABD21EE02&fileName=/typescript-4.0.0-insiders.20200513.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

Kingwl · 2020-05-14T13:45:23Z

Ping, need some help. Please take a look
@sheetalkamat, @amcasey, @mjbvz, @minestarks, @DanielRosenwasser

Kingwl · 2020-05-14T14:20:46Z

Another problem is, where's the line:

a.b.c.d // c is deprecated

What is the expected behavior?

[a.b.c].d
a.b.[c].d
a.b.[c.d]

And if:

a.b.c.d // c and d is deprecated

What is the expected behavior

[a.b.c.d]
a.b.[c].[d]
a.b.[c.d]

amcasey · 2020-05-14T19:38:27Z

@Kingwl, sorry, I'm not sure I understand your question. Are you asking about the design of the features? If so, you probably want @sandersn.

Kingwl · 2020-05-15T01:21:30Z

Does the protocol looks good？I'm not sure🤷‍♂️

src/compiler/checker.ts

src/compiler/diagnosticMessages.json

src/services/completions.ts

src/compiler/types.ts

spahnke · 2020-05-17T08:52:01Z

I believe this would also fix #33093

Kingwl · 2020-05-18T14:28:34Z

Finally, It passed tests. I'll add more tests soon.
@typescript-bot pack this.

typescript-bot · 2020-05-18T14:28:40Z

Heya @Kingwl, I've started to run the tarball bundle task on this PR at ceeaead. You can monitor the build here.

typescript-bot · 2020-05-18T14:43:33Z

Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/74212/artifacts?artifactName=tgz&fileId=2056AC579024F64F4D733979778E0700E6D317EE140EA5F9D238E4B88C38090F02&fileName=/typescript-4.0.0-insiders.20200518.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

sheetalkamat · 2020-05-18T18:07:28Z

src/compiler/binder.ts

                }
            }

+            symbol.isDeprecated = symbol.isDeprecated || isDeprecated;


SHould this be SymbolFlags instead?

I agree -- if there's space there. I think the limit is 29 so there's 1 left.

Alternatively, making this a ModifierFlag would go well with public/@public et al. It would also go better with getNodeModifiers in services.

typescript-bot · 2020-06-18T19:17:42Z

@Kingwl
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..38523

_Metric	_master	₃₈₅₂₃	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{340,211k (± 0.02%)}	_{339,838k (± 0.02%)}	_{-373k (- 0.11%)}	_339,673k	_339,959k
_{Parse Time}	_{1.98s (± 0.59%)}	_{1.98s (± 0.70%)}	_{+0.00s (+ 0.00%)}	_1.94s	_2.01s
_{Bind Time}	_{0.81s (± 1.32%)}	_{0.80s (± 0.59%)}	_{-0.00s (- 0.37%)}	_0.79s	_0.81s
_{Check Time}	_{4.68s (± 0.56%)}	_{4.71s (± 0.57%)}	_{+0.02s (+ 0.51%)}	_4.65s	_4.79s
_{Emit Time}	_{5.21s (± 0.79%)}	_{5.18s (± 0.41%)}	_{-0.03s (- 0.52%)}	_5.13s	_5.22s
_{Total Time}	_{12.67s (± 0.48%)}	_{12.66s (± 0.38%)}	_{-0.01s (- 0.05%)}	_12.57s	_12.79s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{338,724k (± 0.01%)}	_{338,774k (± 0.02%)}	_{+50k (+ 0.01%)}	_338,667k	_338,949k
_{Parse Time}	_{1.55s (± 0.69%)}	_{1.55s (± 0.62%)}	_{-0.00s (- 0.19%)}	_1.52s	_1.57s
_{Bind Time}	_{0.69s (± 0.58%)}	_{0.69s (± 0.69%)}	_{-0.00s (- 0.29%)}	_0.68s	_0.70s
_{Check Time}	_{4.85s (± 0.56%)}	_{4.84s (± 0.49%)}	_{-0.01s (- 0.12%)}	_4.78s	_4.88s
_{Emit Time}	_{2.75s (± 0.49%)}	_{2.73s (± 0.55%)}	_{-0.01s (- 0.55%)}	_2.70s	_2.76s
_{Total Time}	_{9.83s (± 0.38%)}	_{9.80s (± 0.23%)}	_{-0.03s (- 0.25%)}	_9.73s	_9.85s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{301,536k (± 0.02%)}	_{301,848k (± 0.03%)}	_{+312k (+ 0.10%)}	_301,663k	_302,032k
_{Parse Time}	_{1.21s (± 1.09%)}	_{1.21s (± 0.91%)}	_{-0.00s (- 0.08%)}	_1.18s	_1.22s
_{Bind Time}	_{0.64s (± 1.47%)}	_{0.65s (± 1.39%)}	_{+0.01s (+ 0.78%)}	_0.62s	_0.66s
_{Check Time}	_{4.35s (± 0.66%)}	_{4.35s (± 0.44%)}	_{+0.00s (+ 0.07%)}	_4.32s	_4.40s
_{Emit Time}	_{2.85s (± 0.97%)}	_{2.87s (± 1.34%)}	_{+0.02s (+ 0.56%)}	_2.77s	_2.94s
_{Total Time}	_{9.04s (± 0.58%)}	_{9.07s (± 0.53%)}	_{+0.03s (+ 0.29%)}	_8.95s	_9.21s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{459,155k (± 0.02%)}	_{459,128k (± 0.01%)}	_{-26k (- 0.01%)}	_459,009k	_459,276k
_{Parse Time}	_{2.02s (± 0.52%)}	_{2.03s (± 0.52%)}	_{+0.00s (+ 0.15%)}	_2.01s	_2.05s
_{Bind Time}	_{0.64s (± 1.32%)}	_{0.65s (± 1.35%)}	_{+0.01s (+ 2.19%)}	_0.64s	_0.67s
_{Check Time}	_{12.80s (± 0.71%)}	_{12.85s (± 0.57%)}	_{+0.05s (+ 0.43%)}	_12.69s	_13.00s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.46s (± 0.63%)}	_{15.53s (± 0.54%)}	_{+0.07s (+ 0.47%)}	_15.38s	_15.72s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{317,588k (± 0.03%)}	_{317,116k (± 0.09%)}	_{-472k (- 0.15%)}	_316,034k	_317,351k
_{Parse Time}	_{1.95s (± 0.39%)}	_{1.93s (± 0.75%)}	_{-0.02s (- 1.28%)}	_1.90s	_1.96s
_{Bind Time}	_{0.78s (± 0.57%)}	_{0.78s (± 0.67%)}	_{-0.00s (- 0.13%)}	_0.77s	_0.79s
_{Check Time}	_{4.57s (± 0.58%)}	_{4.59s (± 0.63%)}	_{+0.02s (+ 0.35%)}	_4.53s	_4.65s
_{Emit Time}	_{5.32s (± 0.53%)}	_{5.31s (± 1.00%)}	_{-0.01s (- 0.23%)}	_5.21s	_5.46s
_{Total Time}	_{12.63s (± 0.37%)}	_{12.61s (± 0.68%)}	_{-0.03s (- 0.20%)}	_12.45s	_12.84s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{321,236k (± 0.02%)}	_{321,314k (± 0.02%)}	_{+79k (+ 0.02%)}	_321,184k	_321,497k
_{Parse Time}	_{1.52s (± 0.60%)}	_{1.51s (± 1.00%)}	_{-0.01s (- 0.66%)}	_1.48s	_1.54s
_{Bind Time}	_{0.67s (± 0.60%)}	_{0.68s (± 1.01%)}	_{+0.00s (+ 0.60%)}	_0.66s	_0.69s
_{Check Time}	_{4.65s (± 0.44%)}	_{4.63s (± 0.37%)}	_{-0.02s (- 0.37%)}	_4.60s	_4.66s
_{Emit Time}	_{2.81s (± 0.44%)}	_{2.80s (± 0.58%)}	_{-0.02s (- 0.53%)}	_2.76s	_2.83s
_{Total Time}	_{9.65s (± 0.28%)}	_{9.61s (± 0.18%)}	_{-0.04s (- 0.38%)}	_9.57s	_9.65s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{285,983k (± 0.02%)}	_{286,294k (± 0.02%)}	_{+311k (+ 0.11%)}	_286,197k	_286,394k
_{Parse Time}	_{1.22s (± 0.79%)}	_{1.23s (± 1.02%)}	_{+0.00s (+ 0.33%)}	_1.20s	_1.26s
_{Bind Time}	_{0.61s (± 0.97%)}	_{0.62s (± 1.33%)}	_{+0.01s (+ 1.63%)}	_0.60s	_0.64s
_{Check Time}	_{4.25s (± 0.54%)}	_{4.25s (± 0.39%)}	_{+0.00s (+ 0.12%)}	_4.22s	_4.30s
_{Emit Time}	_{2.90s (± 0.69%)}	_{2.91s (± 1.02%)}	_{+0.00s (+ 0.07%)}	_2.83s	_2.97s
_{Total Time}	_{8.99s (± 0.43%)}	_{9.00s (± 0.44%)}	_{+0.02s (+ 0.20%)}	_8.90s	_9.09s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{437,736k (± 0.02%)}	_{437,626k (± 0.01%)}	_{-110k (- 0.03%)}	_437,520k	_437,782k
_{Parse Time}	_{1.99s (± 0.58%)}	_{2.01s (± 0.76%)}	_{+0.02s (+ 0.95%)}	_1.99s	_2.05s
_{Bind Time}	_{0.63s (± 0.98%)}	_{0.63s (± 1.05%)}	_{-0.00s (- 0.16%)}	_0.61s	_0.64s
_{Check Time}	_{11.45s (± 0.52%)}	_{11.45s (± 0.56%)}	_{+0.00s (+ 0.04%)}	_11.34s	_11.66s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.07s (± 0.41%)}	_{14.09s (± 0.42%)}	_{+0.02s (+ 0.16%)}	_14.01s	_14.28s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{336,631k (± 0.02%)}	_{336,369k (± 0.02%)}	_{-262k (- 0.08%)}	_336,259k	_336,489k
_{Parse Time}	_{2.49s (± 0.57%)}	_{2.49s (± 0.73%)}	_{+0.00s (+ 0.12%)}	_2.46s	_2.54s
_{Bind Time}	_{0.83s (± 0.60%)}	_{0.83s (± 0.70%)}	_{+0.01s (+ 0.97%)}	_0.82s	_0.84s
_{Check Time}	_{5.31s (± 0.50%)}	_{5.36s (± 0.60%)}	_{+0.05s (+ 0.88%)}	_5.27s	_5.44s
_{Emit Time}	_{5.90s (± 1.04%)}	_{5.97s (± 1.06%)}	_{+0.07s (+ 1.20%)}	_5.83s	_6.10s
_{Total Time}	_{14.53s (± 0.46%)}	_{14.65s (± 0.62%)}	_{+0.13s (+ 0.87%)}	_14.49s	_14.85s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{340,066k (± 0.01%)}	_{340,145k (± 0.01%)}	_{+79k (+ 0.02%)}	_340,063k	_340,233k
_{Parse Time}	_{1.85s (± 0.57%)}	_{1.85s (± 0.48%)}	_{+0.00s (+ 0.22%)}	_1.84s	_1.88s
_{Bind Time}	_{0.86s (± 0.46%)}	_{0.86s (± 0.52%)}	_{+0.00s (+ 0.12%)}	_0.85s	_0.87s
_{Check Time}	_{5.33s (± 0.38%)}	_{5.33s (± 0.53%)}	_{+0.00s (+ 0.08%)}	_5.29s	_5.39s
_{Emit Time}	_{3.21s (± 0.53%)}	_{3.20s (± 0.54%)}	_{-0.01s (- 0.19%)}	_3.17s	_3.24s
_{Total Time}	_{11.25s (± 0.24%)}	_{11.25s (± 0.42%)}	_{+0.00s (+ 0.03%)}	_11.15s	_11.36s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{303,226k (± 0.01%)}	_{303,498k (± 0.01%)}	_{+272k (+ 0.09%)}	_303,431k	_303,576k
_{Parse Time}	_{1.54s (± 0.26%)}	_{1.54s (± 0.50%)}	_{+0.00s (+ 0.00%)}	_1.53s	_1.56s
_{Bind Time}	_{0.65s (± 0.76%)}	_{0.65s (± 0.53%)}	_{+0.00s (+ 0.15%)}	_0.64s	_0.65s
_{Check Time}	_{4.96s (± 1.74%)}	_{4.93s (± 1.80%)}	_{-0.03s (- 0.54%)}	_4.81s	_5.13s
_{Emit Time}	_{3.05s (± 3.38%)}	_{3.06s (± 3.18%)}	_{+0.01s (+ 0.46%)}	_2.81s	_3.24s
_{Total Time}	_{10.19s (± 0.61%)}	_{10.19s (± 0.53%)}	_{-0.01s (- 0.06%)}	_10.09s	_10.33s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{463,424k (± 0.01%)}	_{463,232k (± 0.01%)}	_{-191k (- 0.04%)}	_463,123k	_463,335k
_{Parse Time}	_{2.35s (± 0.51%)}	_{2.37s (± 0.49%)}	_{+0.01s (+ 0.55%)}	_2.34s	_2.39s
_{Bind Time}	_{0.76s (± 0.81%)}	_{0.77s (± 0.87%)}	_{+0.01s (+ 0.79%)}	_0.76s	_0.78s
_{Check Time}	_{16.97s (± 0.50%)}	_{16.94s (± 0.88%)}	_{-0.03s (- 0.17%)}	_16.61s	_17.28s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{20.08s (± 0.42%)}	_{20.07s (± 0.71%)}	_{-0.01s (- 0.05%)}	_19.77s	_20.40s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{193,160k (± 0.01%)}	_{193,040k (± 0.02%)}	_{-120k (- 0.06%)}	_192,942k	_193,128k
_{Parse Time}	_{2.42s (± 0.70%)}	_{2.41s (± 0.65%)}	_{-0.01s (- 0.37%)}	_2.38s	_2.45s
_{Bind Time}	_{0.97s (± 0.57%)}	_{0.97s (± 0.85%)}	_{+0.00s (+ 0.21%)}	_0.95s	_0.99s
_{Check Time}	_{4.78s (± 0.54%)}	_{4.78s (± 0.55%)}	_{+0.00s (+ 0.02%)}	_4.73s	_4.84s
_{Emit Time}	_{5.98s (± 1.03%)}	_{5.88s (± 1.07%)}	_{-0.10s (- 1.70%)}	_5.71s	_5.98s
_{Total Time}	_{14.15s (± 0.57%)}	_{14.04s (± 0.43%)}	_{-0.11s (- 0.76%)}	_13.85s	_14.17s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{193,139k (± 0.02%)}	_{193,179k (± 0.01%)}	_{+40k (+ 0.02%)}	_193,126k	_193,241k
_{Parse Time}	_{1.89s (± 1.30%)}	_{1.89s (± 0.68%)}	_{-0.01s (- 0.37%)}	_1.85s	_1.91s
_{Bind Time}	_{0.68s (± 0.59%)}	_{0.68s (± 0.70%)}	_{-0.00s (- 0.29%)}	_0.67s	_0.69s
_{Check Time}	_{5.40s (± 1.97%)}	_{5.45s (± 0.37%)}	_{+0.05s (+ 0.96%)}	_5.41s	_5.50s
_{Emit Time}	_{2.76s (± 3.52%)}	_{2.67s (± 0.82%)}	_{🟩-0.09s (- 3.23%)}	_2.62s	_2.73s
_{Total Time}	_{10.72s (± 0.53%)}	_{10.68s (± 0.24%)}	_{-0.04s (- 0.40%)}	_10.63s	_10.73s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{173,321k (± 0.02%)}	_{173,512k (± 0.02%)}	_{+191k (+ 0.11%)}	_173,448k	_173,642k
_{Parse Time}	_{1.58s (± 1.03%)}	_{1.58s (± 0.73%)}	_{-0.01s (- 0.38%)}	_1.55s	_1.60s
_{Bind Time}	_{0.62s (± 1.08%)}	_{0.61s (± 0.73%)}	_{-0.00s (- 0.81%)}	_0.60s	_0.62s
_{Check Time}	_{4.61s (± 0.44%)}	_{4.61s (± 0.68%)}	_{0.00s ( 0.00%)}	_4.56s	_4.70s
_{Emit Time}	_{2.78s (± 1.33%)}	_{2.78s (± 1.18%)}	_{+0.00s (+ 0.14%)}	_2.70s	_2.88s
_{Total Time}	_{9.59s (± 0.43%)}	_{9.59s (± 0.54%)}	_{-0.01s (- 0.08%)}	_9.49s	_9.70s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{262,246k (± 0.02%)}	_{262,174k (± 0.02%)}	_{-72k (- 0.03%)}	_262,061k	_262,249k
_{Parse Time}	_{2.42s (± 0.62%)}	_{2.43s (± 0.52%)}	_{+0.00s (+ 0.21%)}	_2.39s	_2.45s
_{Bind Time}	_{0.66s (± 1.34%)}	_{0.66s (± 0.89%)}	_{+0.01s (+ 1.07%)}	_0.65s	_0.68s
_{Check Time}	_{15.48s (± 0.68%)}	_{15.46s (± 0.91%)}	_{-0.02s (- 0.13%)}	_15.22s	_15.95s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{18.56s (± 0.64%)}	_{18.56s (± 0.74%)}	_{-0.01s (- 0.03%)}	_18.32s	_19.02s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₈₅₂₃	₁₀
_Baseline	_master	₁₀

sandersn

So to recap: we now have NodeFlags.Deprecated, SymbolFlags.Deprecated and ModifierFlags.Deprecated.

I would say we are well-positioned to deprecate things now. =)

sandersn · 2020-06-19T00:41:48Z

It's in! Thanks so much for your persistence @Kingwl!

G-Rath · 2020-06-19T01:06:22Z

I've not followed this feature much, so while I've done a quick read over the discussions, linked tickets & searched the issue tracker I still could have missed something or misunderstood entirely, but just in case:

Has anyone raised the behaviour of removeComments in regards to this feature? I know a few libraries that use that flag, and so this feature is a bit moot if it removes @deprecated comments.

Happy to open a new issue for discussion.

Just found #14619, which would resolve this problem.

Kingwl · 2020-06-19T02:57:46Z

@typescript-bot pack this.

typescript-bot · 2020-06-19T02:57:50Z

Heya @Kingwl, I've started to run the tarball bundle task on this PR at 6434447. You can monitor the build here.

brabenetz · 2020-08-31T09:15:49Z

Does it works with a comment which explain why something is deprecated?
I saw not a singe example with a comment!?
Like:

/** @deprecated replaced by new method .... */
public myOldMethod() {
...

VSCode should than show that message.
And tslint should enforce a comment.

# Why _This follows the TS 4.0 update PR: #9960_ Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~. See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523 # How - Added appropriate annotations to every possible deprecated Expo API that I found. - Updated existing comments to play nice with VS Code messages Also, added note about dead code in Notifications, which is related to #9563 (I forgot to add it then) > Not sure what to do with changelogs ❓ # Test Plan Tested messages in VS Code with _TS 4.0.2_ enabled.

Kingwl · 2020-09-01T14:59:02Z

Seems work for me

# Why _This follows the TS 4.0 update PR: #9960_ Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~. See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523 # How - Added appropriate annotations to every possible deprecated Expo API that I found. - Updated existing comments to play nice with VS Code messages Also, added note about dead code in Notifications, which is related to expo#9563 (I forgot to add it then) > Not sure what to do with changelogs ❓ # Test Plan Tested messages in VS Code with _TS 4.0.2_ enabled.

paulyoung · 2023-09-06T00:30:33Z

Is there a way to suppress this warning using // eslint-disable-next-line or similar?

# Why _This follows the TS 4.0 update PR: #9960_ Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~. See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523 # How - Added appropriate annotations to every possible deprecated Expo API that I found. - Updated existing comments to play nice with VS Code messages Also, added note about dead code in Notifications, which is related to expo#9563 (I forgot to add it then) > Not sure what to do with changelogs ❓ # Test Plan Tested messages in VS Code with _TS 4.0.2_ enabled.

# Why _This follows the TS 4.0 update PR: #9960_ Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~. See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523 # How - Added appropriate annotations to every possible deprecated Expo API that I found. - Updated existing comments to play nice with VS Code messages Also, added note about dead code in Notifications, which is related to #9563 (I forgot to add it then) > Not sure what to do with changelogs ❓ # Test Plan Tested messages in VS Code with _TS 4.0.2_ enabled.

Kingwl changed the title ~~Add deprecated related feature~~ [Expirement] [WIP] Add deprecated related feature May 13, 2020

Kingwl mentioned this pull request May 13, 2020

Build error #38525

Merged

Kingwl mentioned this pull request May 13, 2020

Add ts/js deprecated support microsoft/vscode#97742

Merged

sandersn self-assigned this May 14, 2020

sheetalkamat reviewed May 15, 2020

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

sheetalkamat reviewed May 15, 2020

View reviewed changes

src/compiler/diagnosticMessages.json Show resolved Hide resolved

sheetalkamat reviewed May 15, 2020

View reviewed changes

src/services/completions.ts Outdated Show resolved Hide resolved

sheetalkamat reviewed May 15, 2020

View reviewed changes

src/compiler/types.ts Show resolved Hide resolved

sheetalkamat reviewed May 18, 2020

View reviewed changes

Kingwl added 7 commits May 20, 2020 10:06

Add deprecated related feature

bb09d38

Add more support

5a8da16

fix navtree

2deadaa

Add identifier check

9847ffb

Add more deprecated

06c8d22

fix crash

03d1ffe

fix more crash

30cea12

sandersn added 2 commits June 18, 2020 16:48

Merge branch 'master' into deprecated_support

7714dbf

set @octokit/rest back to latest

6b30216

sandersn approved these changes Jun 18, 2020

View reviewed changes

fix trailing spacel int

6434447

sandersn merged commit 59ad375 into microsoft:master Jun 19, 2020

Kingwl deleted the deprecated_support branch June 19, 2020 02:57

pi0 referenced this pull request in nuxt/nuxt Jun 23, 2020

fix(types): fix Configuration interface

dac1e39

andrewbranch mentioned this pull request Jun 24, 2020

@deprecated appears for any element access that might access a deprecated member #39246

Closed

rbuckton mentioned this pull request Jul 7, 2020

values are marked deprecated when only type has @deprecated #39474

Closed

fbartho mentioned this pull request Aug 9, 2020

maxContentSizeMultiplier prop not working on Text microsoft/reactxp#1052

Open

lijuenc mentioned this pull request Aug 19, 2020

Handling deprecation in Kaizen cultureamp/kaizen-design-system#701

Closed

maapteh mentioned this pull request Aug 26, 2020

have deprecated also work in generated hooks dotansimha/graphql-code-generator#4642

Closed

barthap mentioned this pull request Aug 27, 2020

[packages] Add @deprecated annotations to deprecated APIs expo/expo#9959

Merged

fregante mentioned this pull request Oct 1, 2020

Rule proposal: avoid using deprecated code typescript-eslint/typescript-eslint#2620

Closed

ajafff mentioned this pull request Jan 3, 2021

getSyntacticModifierFlags return value affected by getEffectiveModifierFlags #42189

Closed

predragnikolic mentioned this pull request Jul 5, 2021

Mark completion items as deprecated if JSDoc says so typescript-language-server/typescript-language-server#227

Merged

github-actions bot mentioned this pull request Oct 4, 2022

[Korean] Fix weird expressions like '_제네릭_' microsoft/TypeScript-Website-Localizations#171

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Conversation

Kingwl commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 13, 2020

Uh oh!

Kingwl commented May 13, 2020

Uh oh!

typescript-bot commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kingwl commented May 13, 2020

Uh oh!

typescript-bot commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kingwl commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kingwl commented May 14, 2020

Uh oh!

amcasey commented May 14, 2020

Uh oh!

Kingwl commented May 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spahnke commented May 17, 2020

Uh oh!

Kingwl commented May 18, 2020

Uh oh!

typescript-bot commented May 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheetalkamat May 18, 2020

Choose a reason for hiding this comment

Uh oh!

sandersn Jun 11, 2020

Choose a reason for hiding this comment

Uh oh!

sandersn Jun 12, 2020

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jun 18, 2020

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

sandersn commented Jun 19, 2020

Uh oh!

G-Rath commented Jun 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kingwl commented Jun 19, 2020

Uh oh!

typescript-bot commented Jun 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brabenetz commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kingwl commented Sep 1, 2020

Uh oh!

paulyoung commented Sep 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Kingwl commented May 13, 2020 •

edited

Loading

typescript-bot commented May 13, 2020 •

edited

Loading

typescript-bot commented May 13, 2020 •

edited

Loading

typescript-bot commented May 13, 2020 •

edited

Loading

Kingwl commented May 14, 2020 •

edited

Loading

typescript-bot commented May 18, 2020 •

edited

Loading

typescript-bot commented May 18, 2020 •

edited

Loading

G-Rath commented Jun 19, 2020 •

edited

Loading

typescript-bot commented Jun 19, 2020 •

edited

Loading

brabenetz commented Aug 31, 2020 •

edited

Loading