[lldb][AIX] Added base file for AIX Register Context PPC64 #173239
+516
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Requesting review @labath @DavidSpickett @DhruvSrivastavaX |
Member
|
@llvm/pr-subscribers-lldb Author: Hemang Gadhavi (HemangGadhavi) ChangesThis PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github:
Full diff: https://github.com/llvm/llvm-project/pull/173239.diff 4 Files Affected:
diff --git a/lldb/source/Plugins/Process/AIX/CMakeLists.txt b/lldb/source/Plugins/Process/AIX/CMakeLists.txt
index 3a6d9ec118e60..f1f9121822736 100644
--- a/lldb/source/Plugins/Process/AIX/CMakeLists.txt
+++ b/lldb/source/Plugins/Process/AIX/CMakeLists.txt
@@ -2,6 +2,7 @@ add_lldb_library(lldbPluginProcessAIX
NativeProcessAIX.cpp
NativeThreadAIX.cpp
NativeRegisterContextAIX.cpp
+ NativeRegisterContextAIX_ppc64.cpp
LINK_COMPONENTS
Support
diff --git a/lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.cpp b/lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.cpp
new file mode 100644
index 0000000000000..aba785753055c
--- /dev/null
+++ b/lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.cpp
@@ -0,0 +1,169 @@
+//===------ NativeRegisterContextAIX_ppc64.cpp ----------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#if defined(__powerpc64__)
+
+#include "NativeRegisterContextAIX_ppc64.h"
+
+using namespace lldb;
+using namespace lldb_private;
+using namespace lldb_private::process_aix;
+
+static const uint32_t g_gpr_regnums_ppc64[] = {
+ gpr_r0_ppc64, gpr_r1_ppc64, gpr_r2_ppc64, gpr_r3_ppc64,
+ gpr_r4_ppc64, gpr_r5_ppc64, gpr_r6_ppc64, gpr_r7_ppc64,
+ gpr_r8_ppc64, gpr_r9_ppc64, gpr_r10_ppc64, gpr_r11_ppc64,
+ gpr_r12_ppc64, gpr_r13_ppc64, gpr_r14_ppc64, gpr_r15_ppc64,
+ gpr_r16_ppc64, gpr_r17_ppc64, gpr_r18_ppc64, gpr_r19_ppc64,
+ gpr_r20_ppc64, gpr_r21_ppc64, gpr_r22_ppc64, gpr_r23_ppc64,
+ gpr_r24_ppc64, gpr_r25_ppc64, gpr_r26_ppc64, gpr_r27_ppc64,
+ gpr_r28_ppc64, gpr_r29_ppc64, gpr_r30_ppc64, gpr_r31_ppc64,
+ gpr_cr_ppc64, gpr_msr_ppc64, gpr_xer_ppc64, gpr_lr_ppc64,
+ gpr_ctr_ppc64, gpr_pc_ppc64,
+ LLDB_INVALID_REGNUM // register sets need to end with this flag
+};
+
+static const uint32_t g_fpr_regnums_ppc64[] = {
+ fpr_f0_ppc64, fpr_f1_ppc64, fpr_f2_ppc64, fpr_f3_ppc64,
+ fpr_f4_ppc64, fpr_f5_ppc64, fpr_f6_ppc64, fpr_f7_ppc64,
+ fpr_f8_ppc64, fpr_f9_ppc64, fpr_f10_ppc64, fpr_f11_ppc64,
+ fpr_f12_ppc64, fpr_f13_ppc64, fpr_f14_ppc64, fpr_f15_ppc64,
+ fpr_f16_ppc64, fpr_f17_ppc64, fpr_f18_ppc64, fpr_f19_ppc64,
+ fpr_f20_ppc64, fpr_f21_ppc64, fpr_f22_ppc64, fpr_f23_ppc64,
+ fpr_f24_ppc64, fpr_f25_ppc64, fpr_f26_ppc64, fpr_f27_ppc64,
+ fpr_f28_ppc64, fpr_f29_ppc64, fpr_f30_ppc64, fpr_f31_ppc64,
+ fpr_fpscr_ppc64,
+ LLDB_INVALID_REGNUM // register sets need to end with this flag
+};
+
+static const uint32_t g_vmx_regnums_ppc64[] = {
+ vmx_vr0_ppc64, vmx_vr1_ppc64, vmx_vr2_ppc64, vmx_vr3_ppc64,
+ vmx_vr4_ppc64, vmx_vr5_ppc64, vmx_vr6_ppc64, vmx_vr7_ppc64,
+ vmx_vr8_ppc64, vmx_vr9_ppc64, vmx_vr10_ppc64, vmx_vr11_ppc64,
+ vmx_vr12_ppc64, vmx_vr13_ppc64, vmx_vr14_ppc64, vmx_vr15_ppc64,
+ vmx_vr16_ppc64, vmx_vr17_ppc64, vmx_vr18_ppc64, vmx_vr19_ppc64,
+ vmx_vr20_ppc64, vmx_vr21_ppc64, vmx_vr22_ppc64, vmx_vr23_ppc64,
+ vmx_vr24_ppc64, vmx_vr25_ppc64, vmx_vr26_ppc64, vmx_vr27_ppc64,
+ vmx_vr28_ppc64, vmx_vr29_ppc64, vmx_vr30_ppc64, vmx_vr31_ppc64,
+ vmx_vscr_ppc64, vmx_vrsave_ppc64,
+ LLDB_INVALID_REGNUM // register sets need to end with this flag
+};
+
+static const uint32_t g_vsx_regnums_ppc64[] = {
+ vsx_vs0_ppc64, vsx_vs1_ppc64, vsx_vs2_ppc64, vsx_vs3_ppc64,
+ vsx_vs4_ppc64, vsx_vs5_ppc64, vsx_vs6_ppc64, vsx_vs7_ppc64,
+ vsx_vs8_ppc64, vsx_vs9_ppc64, vsx_vs10_ppc64, vsx_vs11_ppc64,
+ vsx_vs12_ppc64, vsx_vs13_ppc64, vsx_vs14_ppc64, vsx_vs15_ppc64,
+ vsx_vs16_ppc64, vsx_vs17_ppc64, vsx_vs18_ppc64, vsx_vs19_ppc64,
+ vsx_vs20_ppc64, vsx_vs21_ppc64, vsx_vs22_ppc64, vsx_vs23_ppc64,
+ vsx_vs24_ppc64, vsx_vs25_ppc64, vsx_vs26_ppc64, vsx_vs27_ppc64,
+ vsx_vs28_ppc64, vsx_vs29_ppc64, vsx_vs30_ppc64, vsx_vs31_ppc64,
+ vsx_vs32_ppc64, vsx_vs33_ppc64, vsx_vs34_ppc64, vsx_vs35_ppc64,
+ vsx_vs36_ppc64, vsx_vs37_ppc64, vsx_vs38_ppc64, vsx_vs39_ppc64,
+ vsx_vs40_ppc64, vsx_vs41_ppc64, vsx_vs42_ppc64, vsx_vs43_ppc64,
+ vsx_vs44_ppc64, vsx_vs45_ppc64, vsx_vs46_ppc64, vsx_vs47_ppc64,
+ vsx_vs48_ppc64, vsx_vs49_ppc64, vsx_vs50_ppc64, vsx_vs51_ppc64,
+ vsx_vs52_ppc64, vsx_vs53_ppc64, vsx_vs54_ppc64, vsx_vs55_ppc64,
+ vsx_vs56_ppc64, vsx_vs57_ppc64, vsx_vs58_ppc64, vsx_vs59_ppc64,
+ vsx_vs60_ppc64, vsx_vs61_ppc64, vsx_vs62_ppc64, vsx_vs63_ppc64,
+ LLDB_INVALID_REGNUM // register sets need to end with this flag
+};
+
+// Number of register sets provided by this context.
+static constexpr int k_num_register_sets = 4;
+
+static const RegisterSet g_reg_sets_ppc64[k_num_register_sets] = {
+ {"General Purpose Registers", "gpr", k_num_gpr_registers_ppc64,
+ g_gpr_regnums_ppc64},
+ {"Floating Point Registers", "fpr", k_num_fpr_registers_ppc64,
+ g_fpr_regnums_ppc64},
+ {"AltiVec/VMX Registers", "vmx", k_num_vmx_registers_ppc64,
+ g_vmx_regnums_ppc64},
+ {"VSX Registers", "vsx", k_num_vsx_registers_ppc64, g_vsx_regnums_ppc64},
+};
+
+NativeRegisterContextAIX_ppc64::NativeRegisterContextAIX_ppc64(
+ const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
+ : NativeRegisterContextAIX(native_thread) {
+ if (target_arch.GetMachine() != llvm::Triple::ppc64)
+ llvm_unreachable("Unhandled target architecture.");
+}
+
+uint32_t NativeRegisterContextAIX_ppc64::GetRegisterSetCount() const {
+ return k_num_register_sets;
+}
+
+const RegisterSet *
+NativeRegisterContextAIX_ppc64::GetRegisterSet(uint32_t set_index) const {
+ if (set_index < k_num_register_sets)
+ return &g_reg_sets_ppc64[set_index];
+
+ return nullptr;
+}
+
+uint32_t NativeRegisterContextAIX_ppc64::GetUserRegisterCount() const {
+ uint32_t count = 0;
+ for (uint32_t set_index = 0; set_index < k_num_register_sets; ++set_index)
+ count += g_reg_sets_ppc64[set_index].num_registers;
+ return count;
+}
+
+Status
+NativeRegisterContextAIX_ppc64::ReadRegister(const RegisterInfo *reg_info,
+ RegisterValue ®_value) {
+ return Status("unimplemented");
+}
+
+Status
+NativeRegisterContextAIX_ppc64::WriteRegister(const RegisterInfo *reg_info,
+ const RegisterValue ®_value) {
+ return Status("unimplemented");
+}
+
+Status NativeRegisterContextAIX_ppc64::ReadAllRegisterValues(
+ lldb::WritableDataBufferSP &data_sp) {
+ return Status("unimplemented");
+}
+
+Status NativeRegisterContextAIX_ppc64::WriteAllRegisterValues(
+ const lldb::DataBufferSP &data_sp) {
+ return Status("unimplemented");
+}
+
+bool NativeRegisterContextAIX_ppc64::IsGPR(unsigned reg) const {
+ return reg <= k_last_gpr_ppc64;
+}
+
+bool NativeRegisterContextAIX_ppc64::IsFPR(unsigned reg) const {
+ return (k_first_fpr_ppc64 <= reg && reg <= k_last_fpr_ppc64);
+}
+
+bool NativeRegisterContextAIX_ppc64::IsVMX(unsigned reg) const {
+ return (reg >= k_first_vmx_ppc64) && (reg <= k_last_vmx_ppc64);
+}
+
+bool NativeRegisterContextAIX_ppc64::IsVSX(unsigned reg) const {
+ return (reg >= k_first_vsx_ppc64) && (reg <= k_last_vsx_ppc64);
+}
+
+uint32_t NativeRegisterContextAIX_ppc64::CalculateFprOffset(
+ const RegisterInfo *reg_info) const {
+ return 0;
+}
+
+uint32_t NativeRegisterContextAIX_ppc64::CalculateVmxOffset(
+ const RegisterInfo *reg_info) const {
+ return 0;
+}
+
+uint32_t NativeRegisterContextAIX_ppc64::CalculateVsxOffset(
+ const RegisterInfo *reg_info) const {
+ return 0;
+}
+
+#endif // defined(__powerpc64__)
diff --git a/lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.h b/lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.h
new file mode 100644
index 0000000000000..77f75777737d1
--- /dev/null
+++ b/lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.h
@@ -0,0 +1,64 @@
+//===------ NativeRegisterContextAIX_ppc64.h --------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#if defined(__powerpc64__)
+
+#ifndef LLDB_SOURCE_PLUGINS_PROCESS_AIX_NATIVEREGISTERCONTEXTAIX_PPC64_H
+#define LLDB_SOURCE_PLUGINS_PROCESS_AIX_NATIVEREGISTERCONTEXTAIX_PPC64_H
+
+#include "Plugins/Process/AIX/NativeRegisterContextAIX.h"
+#include "Plugins/Process/Utility/lldb-ppc64-register-enums.h"
+
+namespace lldb_private {
+namespace process_aix {
+
+class NativeProcessAIX;
+
+class NativeRegisterContextAIX_ppc64 : public NativeRegisterContextAIX {
+public:
+ NativeRegisterContextAIX_ppc64(const ArchSpec &target_arch,
+ NativeThreadProtocol &native_thread);
+
+ uint32_t GetRegisterSetCount() const override;
+
+ uint32_t GetUserRegisterCount() const override;
+
+ const RegisterSet *GetRegisterSet(uint32_t set_index) const override;
+
+ Status ReadRegister(const RegisterInfo *reg_info,
+ RegisterValue ®_value) override;
+
+ Status WriteRegister(const RegisterInfo *reg_info,
+ const RegisterValue ®_value) override;
+
+ Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
+
+ Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
+
+private:
+ bool IsGPR(unsigned reg) const;
+
+ bool IsFPR(unsigned reg) const;
+
+ bool IsVMX(unsigned reg) const;
+
+ bool IsVSX(unsigned reg) const;
+
+ uint32_t CalculateFprOffset(const RegisterInfo *reg_info) const;
+
+ uint32_t CalculateVmxOffset(const RegisterInfo *reg_info) const;
+
+ uint32_t CalculateVsxOffset(const RegisterInfo *reg_info) const;
+};
+
+} // namespace process_aix
+} // namespace lldb_private
+
+#endif // #ifndef LLDB_SOURCE_PLUGINS_PROCESS_AIX_NATIVEREGISTERCONTEXTAIX_H
+
+#endif // defined(__powerpc64__)
diff --git a/lldb/source/Plugins/Process/Utility/lldb-ppc64-register-enums.h b/lldb/source/Plugins/Process/Utility/lldb-ppc64-register-enums.h
index 40a75c006d843..19525b2c4ee34 100644
--- a/lldb/source/Plugins/Process/Utility/lldb-ppc64-register-enums.h
+++ b/lldb/source/Plugins/Process/Utility/lldb-ppc64-register-enums.h
@@ -127,10 +127,78 @@ enum {
vmx_vrsave_ppc64,
k_last_vmx_ppc64 = vmx_vrsave_ppc64,
+ k_first_vsx_ppc64,
+ vsx_vs0_ppc64 = k_first_vsx_ppc64,
+ vsx_vs1_ppc64,
+ vsx_vs2_ppc64,
+ vsx_vs3_ppc64,
+ vsx_vs4_ppc64,
+ vsx_vs5_ppc64,
+ vsx_vs6_ppc64,
+ vsx_vs7_ppc64,
+ vsx_vs8_ppc64,
+ vsx_vs9_ppc64,
+ vsx_vs10_ppc64,
+ vsx_vs11_ppc64,
+ vsx_vs12_ppc64,
+ vsx_vs13_ppc64,
+ vsx_vs14_ppc64,
+ vsx_vs15_ppc64,
+ vsx_vs16_ppc64,
+ vsx_vs17_ppc64,
+ vsx_vs18_ppc64,
+ vsx_vs19_ppc64,
+ vsx_vs20_ppc64,
+ vsx_vs21_ppc64,
+ vsx_vs22_ppc64,
+ vsx_vs23_ppc64,
+ vsx_vs24_ppc64,
+ vsx_vs25_ppc64,
+ vsx_vs26_ppc64,
+ vsx_vs27_ppc64,
+ vsx_vs28_ppc64,
+ vsx_vs29_ppc64,
+ vsx_vs30_ppc64,
+ vsx_vs31_ppc64,
+ vsx_vs32_ppc64,
+ vsx_vs33_ppc64,
+ vsx_vs34_ppc64,
+ vsx_vs35_ppc64,
+ vsx_vs36_ppc64,
+ vsx_vs37_ppc64,
+ vsx_vs38_ppc64,
+ vsx_vs39_ppc64,
+ vsx_vs40_ppc64,
+ vsx_vs41_ppc64,
+ vsx_vs42_ppc64,
+ vsx_vs43_ppc64,
+ vsx_vs44_ppc64,
+ vsx_vs45_ppc64,
+ vsx_vs46_ppc64,
+ vsx_vs47_ppc64,
+ vsx_vs48_ppc64,
+ vsx_vs49_ppc64,
+ vsx_vs50_ppc64,
+ vsx_vs51_ppc64,
+ vsx_vs52_ppc64,
+ vsx_vs53_ppc64,
+ vsx_vs54_ppc64,
+ vsx_vs55_ppc64,
+ vsx_vs56_ppc64,
+ vsx_vs57_ppc64,
+ vsx_vs58_ppc64,
+ vsx_vs59_ppc64,
+ vsx_vs60_ppc64,
+ vsx_vs61_ppc64,
+ vsx_vs62_ppc64,
+ vsx_vs63_ppc64,
+ k_last_vsx_ppc64 = vsx_vs63_ppc64,
+
k_num_registers_ppc64,
k_num_gpr_registers_ppc64 = k_last_gpr_ppc64 - k_first_gpr_ppc64 + 1,
k_num_fpr_registers_ppc64 = k_last_fpr_ppc64 - k_first_fpr_ppc64 + 1,
k_num_vmx_registers_ppc64 = k_last_vmx_ppc64 - k_first_vmx_ppc64 + 1,
+ k_num_vsx_registers_ppc64 = k_last_vsx_ppc64 - k_first_vsx_ppc64 + 1,
};
#endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_LLDB_PPC64_REGISTER_ENUMS_H
|
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
HemangGadhavi
force-pushed
the
aix_regicontextppc
branch
from
74d1ebf to
6e271cf
Compare
You can test this locally with the following command:git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.cpp lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX_ppc64.h lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64.h lldb/source/Plugins/Process/Utility/lldb-ppc64-register-enums.h lldb/source/Utility/PPC64_DWARF_Registers.h --diff_from_common_commit
View the diff from clang-format here.diff --git a/lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64.h b/lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64.h
index c8b6e592e..4f5bcf749 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64.h
+++ b/lldb/source/Plugins/Process/Utility/RegisterInfos_ppc64.h
@@ -143,19 +143,19 @@
DEFINE_FPR_PPC64(f29, NULL, LLDB_INVALID_REGNUM), \
DEFINE_FPR_PPC64(f30, NULL, LLDB_INVALID_REGNUM), \
DEFINE_FPR_PPC64(f31, NULL, LLDB_INVALID_REGNUM), \
- {"fpscr", \
- NULL, \
- 8, \
- FPR_PPC64_OFFSET(fpscr), \
- lldb::eEncodingUint, \
- lldb::eFormatHex, \
- {ppc64_dwarf::dwarf_fpscr_ppc64, \
- ppc64_dwarf::dwarf_fpscr_ppc64, LLDB_INVALID_REGNUM, \
- LLDB_INVALID_REGNUM, fpr_fpscr_ppc64}, \
- NULL, \
- NULL, \
- NULL, \
- }, \
+ { \
+ "fpscr", \
+ NULL, \
+ 8, \
+ FPR_PPC64_OFFSET(fpscr), \
+ lldb::eEncodingUint, \
+ lldb::eFormatHex, \
+ {ppc64_dwarf::dwarf_fpscr_ppc64, ppc64_dwarf::dwarf_fpscr_ppc64, \
+ LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, fpr_fpscr_ppc64}, \
+ NULL, \
+ NULL, \
+ NULL, \
+ }, \
DEFINE_VMX_PPC64(vr0, LLDB_INVALID_REGNUM), \
DEFINE_VMX_PPC64(vr1, LLDB_INVALID_REGNUM), \
DEFINE_VMX_PPC64(vr2, LLDB_INVALID_REGNUM), \
@@ -188,31 +188,32 @@
DEFINE_VMX_PPC64(vr29, LLDB_INVALID_REGNUM), \
DEFINE_VMX_PPC64(vr30, LLDB_INVALID_REGNUM), \
DEFINE_VMX_PPC64(vr31, LLDB_INVALID_REGNUM), \
- {"vscr", \
- NULL, \
- 4, \
- VMX_PPC64_OFFSET(vscr), \
- lldb::eEncodingUint, \
- lldb::eFormatHex, \
- {ppc64_dwarf::dwarf_vscr_ppc64, ppc64_dwarf::dwarf_vscr_ppc64, \
- LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, vmx_vscr_ppc64}, \
- NULL, \
- NULL, \
- NULL, \
- }, \
- {"vrsave", \
- NULL, \
- 4, \
- VMX_PPC64_OFFSET(vrsave), \
- lldb::eEncodingUint, \
- lldb::eFormatHex, \
- {ppc64_dwarf::dwarf_vrsave_ppc64, \
- ppc64_dwarf::dwarf_vrsave_ppc64, LLDB_INVALID_REGNUM, \
- LLDB_INVALID_REGNUM, vmx_vrsave_ppc64}, \
- NULL, \
- NULL, \
- NULL, \
- }, \
+ { \
+ "vscr", \
+ NULL, \
+ 4, \
+ VMX_PPC64_OFFSET(vscr), \
+ lldb::eEncodingUint, \
+ lldb::eFormatHex, \
+ {ppc64_dwarf::dwarf_vscr_ppc64, ppc64_dwarf::dwarf_vscr_ppc64, \
+ LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, vmx_vscr_ppc64}, \
+ NULL, \
+ NULL, \
+ NULL, \
+ }, \
+ { \
+ "vrsave", \
+ NULL, \
+ 4, \
+ VMX_PPC64_OFFSET(vrsave), \
+ lldb::eEncodingUint, \
+ lldb::eFormatHex, \
+ {ppc64_dwarf::dwarf_vrsave_ppc64, ppc64_dwarf::dwarf_vrsave_ppc64, \
+ LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, vmx_vrsave_ppc64}, \
+ NULL, \
+ NULL, \
+ NULL, \
+ }, \
DEFINE_VSX_PPC64(vs0, LLDB_INVALID_REGNUM), \
DEFINE_VSX_PPC64(vs1, LLDB_INVALID_REGNUM), \
DEFINE_VSX_PPC64(vs2, LLDB_INVALID_REGNUM), \
|
HemangGadhavi
force-pushed
the
aix_regicontextppc
branch
2 times, most recently
from
3dac317 to
7c614d2
Compare
DhruvSrivastavaX
assigned
DavidSpickett and
labath and unassigned
DavidSpickett and
labath
Contributor
Author
|
Please note that the code formatting is failing due to some existing code in RegisterInfos_ppc64.h. Kindly review the changes without considering the code formatting for now; we can address and fix the formatting after the review if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github:
The complete changes for porting are present in this draft PR:
Extending LLDB to work on AIX #102601