-
-
Notifications
You must be signed in to change notification settings - Fork 54
Support for android 12 & IOS in example #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3b651de
2aabdfb
11f67e5
99d55c9
f98877e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ | |
| *.ipr | ||
| *.iws | ||
| .idea/ | ||
| gradle.properties | ||
|
|
||
|
|
||
| # Visual Studio Code related | ||
| .vscode/ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| org.gradle.jvmargs=-Xmx4608M | ||
| android.useAndroidX=true | ||
| android.enableJetifier=true | ||
| android.injected.testOnly=false |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig" | ||
| #include "Generated.xcconfig" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig" | ||
| #include "Pods/Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig" | ||
| #include "Generated.xcconfig" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Uncomment the next line to define a global platform for your project | ||
| platform :ios, '12.0' | ||
|
|
||
| target 'Runner' do | ||
| # Comment the next line if you don't want to use dynamic frameworks | ||
| use_frameworks! | ||
|
|
||
| # Pods for Runner | ||
|
|
||
| end |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| PODFILE CHECKSUM: f5748560085ec8ebfe08aae78c44fe688e24c69e | ||
|
|
||
| COCOAPODS: 1.11.3 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| import 'dart:async'; | ||
|
|
||
| import 'package:flutter/foundation.dart'; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter/services.dart' show rootBundle; | ||
| import 'package:flutter/widgets.dart'; | ||
|
|
@@ -60,7 +59,7 @@ class DotEnv { | |
| /// Loads environment variables from the env file into a map | ||
| /// Merge with any entries defined in [mergeWith] | ||
| Future<void> load( | ||
| {String fileName = '.env', Parser parser = const Parser(), Map<String, String> mergeWith = const {}}) async { | ||
| {String fileName = '.env',Parser parser = const Parser(),Map<String, String> mergeWith = const {}}) async { | ||
| clean(); | ||
| final linesFromFile = await _getEntriesFromFile(fileName); | ||
| final linesFromMergeWith = mergeWith.entries.map((entry) => "${entry.key}=${entry.value}").toList(); | ||
|
|
@@ -71,7 +70,9 @@ class DotEnv { | |
| } | ||
|
|
||
| void testLoad( | ||
| {String fileInput = '', Parser parser = const Parser(), Map<String, String> mergeWith = const {}}) { | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's caused these formatting changes throughout? Is this an IDE preference? Can we revert formatting changes for the sake of reviewing the diff? Unless these formatting options are from the analyser. |
||
| {String fileInput = '', | ||
| Parser parser = const Parser(), | ||
| Map<String, String> mergeWith = const {}}) { | ||
| clean(); | ||
| final linesFromFile = fileInput.split('\n'); | ||
| final linesFromMergeWith = mergeWith.entries.map((entry) => "${entry.key}=${entry.value}").toList(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking this is defined & we haven't missed defining it?
Ideally I should add some CI tests to check app boots and lib works on app etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I revert this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we replace
"${applicationName}"with"io.flutter.app.FlutterApplication"it will throw error like