Support for android 12 & IOS in example #60
Conversation
|
@java-james please have a look 🙏 |
|
Thanks @pranavo72bex. Looks ok I will have to give it a spin on device |
| } | ||
|
|
||
| void testLoad( | ||
| {String fileInput = '', Parser parser = const Parser(), Map<String, String> mergeWith = const {}}) { |
There was a problem hiding this comment.
What's caused these formatting changes throughout? Is this an IDE preference? Can we revert formatting changes for the sake of reviewing the diff? Unless these formatting options are from the analyser.
|
@java-james Please check 🙏 |
| FlutterApplication and put your custom class here. --> | ||
| <application | ||
| android:name="io.flutter.app.FlutterApplication" | ||
| android:name="${applicationName}" |
There was a problem hiding this comment.
Just checking this is defined & we haven't missed defining it?
Ideally I should add some CI tests to check app boots and lib works on app etc
There was a problem hiding this comment.
Should I revert this change ?
There was a problem hiding this comment.
Just checking this is defined & we haven't missed defining it?
Ideally I should add some CI tests to check app boots and lib works on app etc
If we replace "${applicationName}" with "io.flutter.app.FlutterApplication" it will throw error like
embedding. It is being deprecated in favor of Android embedding v2. Follow the
steps at
https://flutter.dev/go/android-project-migration
to migrate your project. You may also pass the --ignore-deprecation flag to
ignore this check and continue with the deprecated v1 embedding. However,
the v1 Android embedding will be removed in future versions of Flutter.```
so we have to use "${applicationName}"
|
Cheers @pranavo72bex LGTM. 1 small comment on application name making sure that's defined. |
|
…. See flutter.dev/go/android-splash-migration for migration steps.
|
@java-james please check |
2 participants
No description provided.