Fix panel active not remove between views and GoBack failure between different view.#901
Fix panel active not remove between views and GoBack failure between different view.#901imaffett merged 1 commit intointel:masterfrom ArcRain:master
Conversation
|
Thanks for the commit. I will review this today. |
|
We now have an issue with the slide up transition. Since you remove active class on it, the content is white as the panel slides up. To test this, open up the kitchen sink app and click touch events. The content view content is hidden, but the header is still available. |
|
https://github.com/01org/appframework/tree/ArcRain-master I pushed a fix up there for the slide up transition. Can you please check it out? |
|
OK. I'll check it out and test again. |
|
I have checked it your fixed version out. Before I replaced changed files, I noticed that the content is white while doing slide up transition. With your fixed version, the issue has gone. |
1)Fix issues #850 #866 #873;
2)Fix explorer GoBack failed between different view;
3)Fix back button appended by code is invalid when 'click' on some device;
4)Add parameter 'back' to indicate whether transition is back in event 'panelunload' and 'panelload';
5)Code review for run 'grunt'
Major fixed issue is about panel active status between different views. Test case can use appframework DEMO. When loginview is modal, activated panel in 'mainview' is still active. After patching my code, the activated panel is remove.
For 'back' in event 'panelunload' and 'panelload', we can know whether transition is back.