This repository was archived by the owner on Apr 16, 2019. It is now read-only.
"active" class not being removed from panels#850
Closed
patrick-lake wants to merge 2 commits intointel:masterfrom
Closed
"active" class not being removed from panels#850patrick-lake wants to merge 2 commits intointel:masterfrom
patrick-lake wants to merge 2 commits intointel:masterfrom
Conversation
Contributor
|
Any chance you can provide a demo showing this? |
Contributor
Author
|
I'll try in the next couple of days. |
added 2 commits
April 9, 2015 13:41
Update af.touchEvents.js
|
I think this is a major bug that need to be addressed. Not sure using a timer to remove the 'active' class style is the best approach. I've reported the bug with an example at #866 |
Contributor
|
@jvence - Then submit a pull request with a sample that has it fixed. That "addresses" it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a situation where navigating using the anchor or loadContent approaches wasn't showing the correct panel. I noticed that the "active" class wasn't being removed from previous panels that had been viewed which was causing the issue.
I'm not sure this is the best approach, but it was the only solution I could come up with that worked. The removal of the class is in a timer so that the panel doesn't disappear before the transition completes.