fix: Rename to fix "Mismatched region tag" check#201

Merged

larkee merged 2 commits intogoogleapis:masterfrom

c24t:lowercase-test

Dec 29, 2020

Contributor

c24t commented Dec 22, 2020

Quick fix for failing "Mismatched region tag" checks like this one.

I didn't change the names of any class-level constants, just the ones defined in individual tests. Even though we only need to rename "START" and "END" to fix the check, I thought it would be better to make them all consistent.


          fix: Rename to fix "Mismatched region tag" check

45087bc

c24t requested a review from a team as a code owner

December 22, 2020 06:52

product-auto-label bot added the api: spanner label

google-cla bot added the cla: yes label

snippet-bot bot commented Dec 22, 2020

Here is the summary of changes.

You deleted 5 region tags.

tests/system/test_system.py:1861, tag + 1
tests/system/test_system.py:1864, tag : START + 1
tests/system/test_system.py:1870, tag : END + 1
tests/system/test_system.py:1882, tag + 1 : END
tests/system/test_system.py:1888, tag + 1 : END + 1

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

larkee approved these changes

View reviewed changes

Contributor

larkee left a comment

LGTM 👍 Good call on the consistency!

c24t added the kokoro:force-run label

yoshi-kokoro removed the kokoro:force-run label

c24t mentioned this pull request

fix: Convert PBs in system test cleanup #199

Merged

c24t added a commit that referenced this pull request


          fix: Convert PBs in system test cleanup (#199)

ede4343

Fixes #198, includes #201.

Fix a bug in test_system.py around backup instance proto conversion.


          Merge branch 'master' into lowercase-test

df99b8d

larkee merged commit c000ec4 into googleapis:master

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 3.0.0 (#208)

58359f9

🤖 I have created a release \*beep\* \*boop\* 
---
## [3.0.0](https://github.com/googleapis/python-spanner/compare/v2.1.0...v3.0.0) (2021-01-15)


### ⚠ BREAKING CHANGES

* convert operations pbs into Operation objects when listing operations (#186)

### Features

* add support for instance labels ([#193](https://github.com/googleapis/python-spanner/issues/193)) ([ed462b5](https://github.com/googleapis/python-spanner/commit/ed462b567a1a33f9105ffb37ba1218f379603614))
* add support for ssl credentials; add throttled field to UpdateDatabaseDdlMetadata ([#161](https://github.com/googleapis/python-spanner/issues/161)) ([2faf01b](https://github.com/googleapis/python-spanner/commit/2faf01b135360586ef27c66976646593fd85fd1e))
* adding missing docstrings for functions & classes  ([#188](https://github.com/googleapis/python-spanner/issues/188)) ([9788cf8](https://github.com/googleapis/python-spanner/commit/9788cf8678d882bd4ccf551f828050cbbb8c8f3a))
* autocommit sample ([#172](https://github.com/googleapis/python-spanner/issues/172)) ([4ef793c](https://github.com/googleapis/python-spanner/commit/4ef793c9cd5d6dec6e92faf159665e11d63762ad))


### Bug Fixes

* convert operations pbs into Operation objects when listing operations ([#186](https://github.com/googleapis/python-spanner/issues/186)) ([ed7152a](https://github.com/googleapis/python-spanner/commit/ed7152adc37290c63e59865265f36c593d9b8da3))
* Convert PBs in system test cleanup ([#199](https://github.com/googleapis/python-spanner/issues/199)) ([ede4343](https://github.com/googleapis/python-spanner/commit/ede4343e518780a4ab13ae83017480d7046464d6))
* **dbapi:** autocommit enabling fails if no transactions begun ([#177](https://github.com/googleapis/python-spanner/issues/177)) ([e981adb](https://github.com/googleapis/python-spanner/commit/e981adb3157bb06e4cb466ca81d74d85da976754))
* **dbapi:** executemany() hiding all the results except the last ([#181](https://github.com/googleapis/python-spanner/issues/181)) ([020dc17](https://github.com/googleapis/python-spanner/commit/020dc17c823dfb65bfaacace14d2c9f491c97e11))
* **dbapi:** Spanner protobuf changes causes KeyError's ([#206](https://github.com/googleapis/python-spanner/issues/206)) ([f1e21ed](https://github.com/googleapis/python-spanner/commit/f1e21edbf37aab93615fd415d61f829d2574916b))
* remove client side gRPC receive limits ([#192](https://github.com/googleapis/python-spanner/issues/192)) ([90effc4](https://github.com/googleapis/python-spanner/commit/90effc4d0f4780b7a7c466169f9fc1e45dab8e7f))
* Rename to fix "Mismatched region tag" check ([#201](https://github.com/googleapis/python-spanner/issues/201)) ([c000ec4](https://github.com/googleapis/python-spanner/commit/c000ec4d9b306baa0d5e9ed95f23c0273d9adf32))


### Documentation

* homogenize region tags ([#194](https://github.com/googleapis/python-spanner/issues/194)) ([1501022](https://github.com/googleapis/python-spanner/commit/1501022239dfa8c20290ca0e0cf6a36e9255732c))
* homogenize region tags pt 2 ([#202](https://github.com/googleapis/python-spanner/issues/202)) ([87789c9](https://github.com/googleapis/python-spanner/commit/87789c939990794bfd91f5300bedc449fd74bd7e))
* update CHANGELOG breaking change comment ([#180](https://github.com/googleapis/python-spanner/issues/180)) ([c7b3b9e](https://github.com/googleapis/python-spanner/commit/c7b3b9e4be29a199618be9d9ffa1d63a9d0f8de7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner cla: yes