fix: Convert PBs in system test cleanup#199
Merged
c24t merged 9 commits intogoogleapis:masterfrom Dec 22, 2020
Merged
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
larkee
approved these changes
Dec 22, 2020
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
Whoops! I can't believe I missed this! Thanks 👍
c24t
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Here is the summary of changes. You deleted 5 region tags.
This comment is generated by snippet-bot.
|
Contributor
Author
|
I suspect the CI errors around tracing spans are because we're creating spans for retries, but now that spanner is healthy we're seeing green builds without any retries (at least in the affected tests, assuming I'm right about the retry spans). If this comes up again we can cherry pick c0923e1 to investigate. I merged #201 in here too, hopefully this gets us a fully green build. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 15, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.0.0](https://github.com/googleapis/python-spanner/compare/v2.1.0...v3.0.0) (2021-01-15) ### ⚠ BREAKING CHANGES * convert operations pbs into Operation objects when listing operations (#186) ### Features * add support for instance labels ([#193](https://github.com/googleapis/python-spanner/issues/193)) ([ed462b5](https://github.com/googleapis/python-spanner/commit/ed462b567a1a33f9105ffb37ba1218f379603614)) * add support for ssl credentials; add throttled field to UpdateDatabaseDdlMetadata ([#161](https://github.com/googleapis/python-spanner/issues/161)) ([2faf01b](https://github.com/googleapis/python-spanner/commit/2faf01b135360586ef27c66976646593fd85fd1e)) * adding missing docstrings for functions & classes ([#188](https://github.com/googleapis/python-spanner/issues/188)) ([9788cf8](https://github.com/googleapis/python-spanner/commit/9788cf8678d882bd4ccf551f828050cbbb8c8f3a)) * autocommit sample ([#172](https://github.com/googleapis/python-spanner/issues/172)) ([4ef793c](https://github.com/googleapis/python-spanner/commit/4ef793c9cd5d6dec6e92faf159665e11d63762ad)) ### Bug Fixes * convert operations pbs into Operation objects when listing operations ([#186](https://github.com/googleapis/python-spanner/issues/186)) ([ed7152a](https://github.com/googleapis/python-spanner/commit/ed7152adc37290c63e59865265f36c593d9b8da3)) * Convert PBs in system test cleanup ([#199](https://github.com/googleapis/python-spanner/issues/199)) ([ede4343](https://github.com/googleapis/python-spanner/commit/ede4343e518780a4ab13ae83017480d7046464d6)) * **dbapi:** autocommit enabling fails if no transactions begun ([#177](https://github.com/googleapis/python-spanner/issues/177)) ([e981adb](https://github.com/googleapis/python-spanner/commit/e981adb3157bb06e4cb466ca81d74d85da976754)) * **dbapi:** executemany() hiding all the results except the last ([#181](https://github.com/googleapis/python-spanner/issues/181)) ([020dc17](https://github.com/googleapis/python-spanner/commit/020dc17c823dfb65bfaacace14d2c9f491c97e11)) * **dbapi:** Spanner protobuf changes causes KeyError's ([#206](https://github.com/googleapis/python-spanner/issues/206)) ([f1e21ed](https://github.com/googleapis/python-spanner/commit/f1e21edbf37aab93615fd415d61f829d2574916b)) * remove client side gRPC receive limits ([#192](https://github.com/googleapis/python-spanner/issues/192)) ([90effc4](https://github.com/googleapis/python-spanner/commit/90effc4d0f4780b7a7c466169f9fc1e45dab8e7f)) * Rename to fix "Mismatched region tag" check ([#201](https://github.com/googleapis/python-spanner/issues/201)) ([c000ec4](https://github.com/googleapis/python-spanner/commit/c000ec4d9b306baa0d5e9ed95f23c0273d9adf32)) ### Documentation * homogenize region tags ([#194](https://github.com/googleapis/python-spanner/issues/194)) ([1501022](https://github.com/googleapis/python-spanner/commit/1501022239dfa8c20290ca0e0cf6a36e9255732c)) * homogenize region tags pt 2 ([#202](https://github.com/googleapis/python-spanner/issues/202)) ([87789c9](https://github.com/googleapis/python-spanner/commit/87789c939990794bfd91f5300bedc449fd74bd7e)) * update CHANGELOG breaking change comment ([#180](https://github.com/googleapis/python-spanner/issues/180)) ([c7b3b9e](https://github.com/googleapis/python-spanner/commit/c7b3b9e4be29a199618be9d9ffa1d63a9d0f8de7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts some Spanner API resource protos following https://github.com/googleapis/python-spanner/blob/master/UPGRADING.md#handwritten-surface-changes, and fixes an apparent bug in the system test.
Fixes #198 🦕