Skip to content

deps: update google-java-format to the latest#1003

Merged
diegomarquezp merged 12 commits intomainfrom
diegomarquezp-patch-1
Mar 24, 2025
Merged

deps: update google-java-format to the latest#1003
diegomarquezp merged 12 commits intomainfrom
diegomarquezp-patch-1

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Mar 20, 2025 •
edited
Loading

b/395190324

BEGIN_COMMIT_OVERRIDE
deps: update google-java-format to the latest
END_COMMIT_OVERRIDE

@diegomarquezp diegomarquezp requested a review from a team March 20, 2025 14:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 20, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 20, 2025
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Mar 21, 2025

All lint failures are due to non-complying files:

Error:  Failed to execute goal com.spotify.fmt:fmt-maven-plugin:2.25:check (default-cli) on project proto-google-cloud-bigtable-v2: Found 99 non-complying files, failing build -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

suztomo
suztomo approved these changes Mar 21, 2025
View reviewed changes
@diegomarquezp diegomarquezp added the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2025
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2025
@diegomarquezp diegomarquezp reopened this Mar 21, 2025
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Mar 21, 2025

@suztomo do you know how to get rid of the old required checks? I tried updating sync-repo-settings in this PR with no luck. Do we need a separate PR?
image

@suztomo
Copy link
Member

suztomo commented Mar 21, 2025

I (repo admin) removed them.

@suztomo
Copy link
Member

suztomo commented Mar 22, 2025 •
edited
Loading

@diegomarquezp Would you plan few items that need to happen in each handwritten repository to get the lint CI fixed?

Error: Failed to execute goal com.spotify.fmt:fmt-maven-plugin:2.25:check (default-cli) on project google-cloud-bigquery: Found 28 non-complying files, failing build -> [Help 1]

Post the plan in the "Google Java Format Requiring Java 17 for CIs" email thread.

@diegomarquezp diegomarquezp merged commit aa78b13 into main Mar 24, 2025
53 of 57 checks passed
@diegomarquezp diegomarquezp deleted the diegomarquezp-patch-1 branch March 24, 2025 14:57
@diegomarquezp diegomarquezp mentioned this pull request Mar 24, 2025
Closed
diegomarquezp added a commit to googleapis/sdk-platform-java that referenced this pull request Mar 24, 2025
@diegomarquezp
chore: update lint workflow template to use Java 17
00ca224 
This PR follows from googleapis/java-shared-config#1003, which updated google-java-format to the latest and is now [requiring](https://github.com/google/google-java-format/releases/tag/v1.25.0) Java 17.

Note that this template will not be spread until #3701, but the changes will be done to prevent regressions when it's fixed.
@diegomarquezp diegomarquezp mentioned this pull request Mar 24, 2025
Open
@diegomarquezp diegomarquezp changed the title chore: update google-java-format to the latest deps: update google-java-format to the latest Mar 26, 2025
@diegomarquezp diegomarquezp added the release-please:force-run To run release-please label Mar 26, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 26, 2025
This was referenced Apr 4, 2025
Merged
Merged
@diegomarquezp diegomarquezp mentioned this pull request Apr 22, 2025
Merged
diegomarquezp added a commit to googleapis/sdk-platform-java that referenced this pull request Apr 22, 2025
@diegomarquezp
fix: use spotify formatter in hermetic build templates (#3752)
65e29da 
Prepares downstream repos for the linter upgrade from java-shared-config
(googleapis/java-shared-config#1003)
diegomarquezp added a commit to googleapis/sdk-platform-java that referenced this pull request Apr 22, 2025
@diegomarquezp
fix: use java 17 in samples.yaml
0b41a3d 
This follows from the linter upgrade done in googleapis/java-shared-config#1003
@diegomarquezp diegomarquezp mentioned this pull request Apr 22, 2025
Merged
diegomarquezp added a commit to googleapis/sdk-platform-java that referenced this pull request Apr 22, 2025
@diegomarquezp
fix: use java 17 in samples.yaml (#3754)
2d5c5e2 
This follows from the linter upgrade done in
googleapis/java-shared-config#1003
diegomarquezp added a commit to googleapis/java-spanner-jdbc that referenced this pull request May 12, 2025
@diegomarquezp
chore: update linter groupd ID to the latest
52ace8e 
Follows from googleapis/java-shared-config#1003
diegomarquezp added a commit to googleapis/java-spanner-jdbc that referenced this pull request May 12, 2025
@diegomarquezp
chore: update linter groupd ID to the latest
31576bf 
Follows from googleapis/java-shared-config#1003
@diegomarquezp diegomarquezp mentioned this pull request May 12, 2025
Closed
diegomarquezp added a commit to googleapis/java-storage-nio that referenced this pull request May 12, 2025
@diegomarquezp
chore: update linter groupd ID to the latest
8b23558 
Follows from googleapis/java-shared-config#1003
@diegomarquezp diegomarquezp mentioned this pull request May 12, 2025
Merged
diegomarquezp added a commit to googleapis/java-logging-logback that referenced this pull request May 12, 2025
@diegomarquezp
chore: update linter to the latest
f1c71d6 
Follows from googleapis/java-shared-config#1003
@diegomarquezp diegomarquezp mentioned this pull request May 12, 2025
Merged
diegomarquezp added a commit to googleapis/java-logging-logback that referenced this pull request May 12, 2025
@diegomarquezp
chore: update linter to the latest and format code (#1473)
14fe327 
* chore: update linter to the latest

Follows from googleapis/java-shared-config#1003

* chore: format files
olavloite pushed a commit to googleapis/java-spanner-jdbc that referenced this pull request May 13, 2025
@diegomarquezp
chore: update linter groupd ID to the latest (#2052)
1a95dab 
* chore: update linter groupd ID to the latest

Follows from googleapis/java-shared-config#1003

* chore: update jvm to 17 in lint job

* chore: reformat files
lqiu96 pushed a commit to googleapis/sdk-platform-java that referenced this pull request Jun 10, 2025
@diegomarquezp @lqiu96
fix: use spotify formatter in hermetic build templates (#3752)
fcc8354 
Prepares downstream repos for the linter upgrade from java-shared-config
(googleapis/java-shared-config#1003)
lqiu96 pushed a commit to googleapis/sdk-platform-java that referenced this pull request Jun 10, 2025
@diegomarquezp @lqiu96
fix: use java 17 in samples.yaml (#3754)
dd1a5e3 
This follows from the linter upgrade done in
googleapis/java-shared-config#1003
lqiu96 pushed a commit to googleapis/sdk-platform-java that referenced this pull request Aug 21, 2025
@diegomarquezp @lqiu96
fix: use spotify formatter in hermetic build templates (#3752)
d3ad83b 
Prepares downstream repos for the linter upgrade from java-shared-config
(googleapis/java-shared-config#1003)
lqiu96 pushed a commit to googleapis/sdk-platform-java that referenced this pull request Aug 21, 2025
@diegomarquezp @lqiu96
fix: use java 17 in samples.yaml (#3754)
87ddc7f 
This follows from the linter upgrade done in
googleapis/java-shared-config#1003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diegomarquezp @suztomo @JoeWang1127