chore: format source code with google-java-format 1.25.2#3737
Closed
diegomarquezp wants to merge 3 commits intomainfrom
Closed
chore: format source code with google-java-format 1.25.2#3737diegomarquezp wants to merge 3 commits intomainfrom
diegomarquezp wants to merge 3 commits intomainfrom
Conversation
product-auto-label
bot
added
size: l
Contributor
Author
|
The lint check will fail while the changes from googleapis/java-shared-config#1003 are not in this repo via sdk-platform-config's next release. |
Member
|
The mvn command changed didn't it? |
Contributor
Author
suztomo
approved these changes
Mar 24, 2025
Member
|
Great. I see the lint job succeeded. |
diegomarquezp
added
the
do not merge
Contributor
Author
|
Thanks for the review. I'm however adding |
Contributor
Author
|
BigQuery is not handled by hermetic build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
googleapis/java-shared-config#1003 was merged in java-shared-config and will bring the latest google-java-format formatter to this repository.
This PR contains:
mvn fmt:formatusing this new version..kokoro/build.shto use thecom.spotify.fmtgroup ID (the fmt plugin changed group ID since 2.14.0).update_generation_config.yamlis not updated in downstream repos sdk-platform-java#3701), so a manual change is needed for the time being.