Skip to content

fix: restore repository: github/gh-aw in dev mode checkout step#20791

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-tests-de63e635-bd16-4f32-8b03-e1441cb38585
Mar 13, 2026
Merged

fix: restore repository: github/gh-aw in dev mode checkout step#20791
pelikhan merged 3 commits intomainfrom
copilot/fix-tests-de63e635-bd16-4f32-8b03-e1441cb38585

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

Summary

PR #20775 accidentally removed repository: github/gh-aw from the dev mode Checkout actions folder step in generateCheckoutActionsFolder. This broke 4 tests in CI run 23051084660.

Root Cause

In pkg/workflow/compiler_yaml_helpers.go, the dev mode branch was missing repository: github/gh-aw:

// Before (broken)
if c.actionMode.IsDev() {
    lines := []string{
        "      - name: Checkout actions folder\n",
        fmt.Sprintf("        uses: %s\n", GetActionPin("actions/checkout")),
        "        with:\n",
        "          sparse-checkout: |\n",   // missing repository: github/gh-aw
        "            actions\n",
        "          persist-credentials: false\n",
    }
    return lines
}

Fix

Restored repository: github/gh-aw to the dev mode checkout step. This is required so cross-repo callers (e.g. event-driven relays) can find the actions/ directory — without it, the runner defaults to the caller's repo which has no actions/ directory, causing Setup Scripts to fail immediately (fix for #20658).

Tests Fixed

  • TestCheckoutActionsFolderDevModeHasRepository — explicitly verifies dev mode includes repository: github/gh-aw
  • TestWasmGolden_CompileFixtures/basic-copilot
  • TestWasmGolden_CompileFixtures/smoke-copilot
  • TestWasmGolden_CompileFixtures/with-imports

No golden file changes needed — they already contained the correct expected output.

Copilot AI and others added 2 commits March 13, 2026 12:40
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Contributor

@copilot recompile

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 13, 2026

@copilot recompile

Done — recompiled all 168 workflow lock files in 67bf76d.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb --jq .object.sha (http block)
  • https://api.github.com/repos/githubnext/agentics/git/ref/tags/
    • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@pelikhan pelikhan marked this pull request as ready for review March 13, 2026 13:19
Copilot AI review requested due to automatic review settings March 13, 2026 13:19
@pelikhan pelikhan merged commit d60d644 into main Mar 13, 2026
@pelikhan pelikhan deleted the copilot/fix-tests-de63e635-bd16-4f32-8b03-e1441cb38585 branch March 13, 2026 13:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores repository: github/gh-aw in the dev-mode “Checkout actions folder” step so cross-repo callers correctly sparse-check out the actions/ directory from the gh-aw repo (fixing CI failures caused by defaulting to the caller’s repo).

Changes:

  • Add repository: github/gh-aw to the dev-mode checkout step emitted by generateCheckoutActionsFolder.
  • Regenerate/update workflow .lock.yml files so their “Checkout actions folder” steps include repository: github/gh-aw.

Reviewed changes

Copilot reviewed 168 out of 168 changed files in this pull request and generated no comments.

File Description
pkg/workflow/compiler_yaml_helpers.go Ensures dev-mode checkout targets github/gh-aw so ./actions/* exists in cross-repo executions.
.github/workflows/*.lock.yml Updates generated lock workflows to include repository: github/gh-aw in “Checkout actions folder” steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants