Use runtime ${{ github.action_ref }} for dev-mode "Checkout actions folder" step#20775
Use runtime ${{ github.action_ref }} for dev-mode "Checkout actions folder" step#20775
${{ github.action_ref }} for dev-mode "Checkout actions folder" step#20775Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
In dev mode, generateCheckoutActionsFolder now returns nil when the compiler version resolves to a git commit SHA (e.g. from a git-describe intermediate build like v1.2.3-60-ge284d1e). The checkout step is only emitted when there is no ref (version == "dev") or the ref is a clean tag (version == "v1.2.3"). - Add isSHA() helper that matches hex-only strings of 4-40 chars - Guard dev-mode checkout with !isSHA(ref) - Update TestCheckoutActionsFolderDevModeWithVersionHasRef to expect nil - Add TestCheckoutActionsFolderDevModeWithGitDescribeSHAIsSkipped - Add TestCheckoutActionsFolderDevModeWithTagVersionGeneratesCheckout Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| if c.actionMode.IsDev() { | ||
| // Skip the checkout when ref resolves to a commit SHA – pinning to an | ||
| // intermediate SHA is not meaningful in a dev workflow. | ||
| if c.actionMode.IsDev() && !isSHA(ref) { |
There was a problem hiding this comment.
@copilot remove the isSHA call. You should emit a ref that resolves to the ref of action being executed. NOT the current ref. This should be a github action macro that resolves at runtime.
There was a problem hiding this comment.
Done in 2a5c538. The isSHA check is removed. The dev-mode checkout now always emits ref: ${{ github.action_ref }}, which resolves at runtime to the ref of the action being executed.
Instead of baking in a compile-time SHA (or skipping the checkout
entirely), the dev-mode Checkout actions folder step now always emits
`ref: ${{ github.action_ref }}`. This runtime expression resolves to
the ref of the action being executed, keeping the checkout in sync
with whatever version is actually running.
Removes the isSHA() helper and gitSHAPattern variable that were added
in the previous approach.
Updates tests to verify the runtime macro is always present in dev
mode regardless of compiler version string.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
${{ github.action_ref }} for dev-mode "Checkout actions folder" step
|
@copilot recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 15e16f7 — all 168 workflow lock files recompiled. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…entics-maintenance.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 5b46305. The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
- Modified multiple workflow files to change the checkout reference from `${{ github.action_ref }}` to `${{ github.action_ref || github.ref }}`. This ensures that the reference resolves correctly in both workflow_call contexts and other triggering contexts such as schedule, workflow_dispatch, and push.
- Updated tests to reflect the new reference format, ensuring that the dev mode checks for the correct reference usage.
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Agent Container Tool Check
Result: 11/12 tools available ❌ Overall Status: FAIL —
|
Smoke Test
Warning
|
Smoke Test Results - Run §23050937333Core Tests: PR Review Tests (#20775): Overall: PARTIAL (Serena MCP EOF errors, push to branch failed in sandbox)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
|
Smoke test results for this PR 🤖
Overall: PR author:
|
There was a problem hiding this comment.
Smoke Test Review — PR #20775
Found a failing test and a description mismatch in this PR.
TestCheckoutActionsFolderDevModeHasRepositoryfails — it still assertsrepository: github/gh-awis in dev-mode output, but the implementation no longer includes it. Verified locally.- The PR description claims dev mode now emits
ref: ${{ github.action_ref }}, but neither the implementation nor the tests reflect this — the ref field is simply absent.
Please update the failing test and clarify whether ref: ${{ github.action_ref }} is intended.
📰 BREAKING: Report filed by Smoke Copilot
| @@ -312,27 +312,22 @@ func TestCheckoutActionsFolderDevModeHasRepository(t *testing.T) { | |||
| if !strings.Contains(combined, "repository: github/gh-aw") { | |||
| t.Error("Dev mode Checkout actions folder should include 'repository: github/gh-aw' (fix for #20658)") | |||
There was a problem hiding this comment.
Test failure detected 🔴
TestCheckoutActionsFolderDevModeHasRepository at line 313 still asserts repository: github/gh-aw is present in the dev-mode checkout output:
if !strings.Contains(combined, "repository: github/gh-aw") {
t.Error("Dev mode Checkout actions folder should include 'repository: github/gh-aw' ...")
}But the PR removes repository: github/gh-aw from the dev-mode block in compiler_yaml_helpers.go. Running go test -run TestCheckoutActionsFolderDevModeHasRepository ./pkg/workflow/ confirms this test fails with the current changes. This test needs to be updated to reflect the new intended behavior.
| " actions\n", | ||
| " persist-credentials: false\n", | ||
| ) | ||
| } |
There was a problem hiding this comment.
PR description vs implementation mismatch
The PR description states:
"The dev-mode checkout step now always emits
ref: $\{\{ github.action_ref }}"
But the dev-mode block here emits only sparse-checkout, actions, and persist-credentials: false — no ref: field at all. The $\{\{ github.action_ref }} runtime expression is neither added to the implementation nor verified in any test.
If ref: $\{\{ github.action_ref }} is the intended behavior, it needs to be added here. If the intent is to omit ref: entirely, the PR description should be updated.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
In dev mode, the compiler was unconditionally emitting a "Checkout actions folder" step without a ref, or (in intermediate builds) baking in a compile-time commit SHA. Using a compile-time SHA in a dev workflow is misleading — the checkout should always track the ref of the action currently being executed.
Changes
compiler_yaml_helpers.go: The dev-mode checkout step now always emitsref: ${{ github.action_ref }}, a GitHub Actions runtime expression that resolves to the ref of the action being executed. Removed theisSHA()helper andgitSHAPatternvariable that were part of an earlier approach.maintenance_workflow.go: The maintenance workflow's dev/script-mode "Checkout actions folder" step now also emitsref: ${{ github.action_ref }}instead of callingversionToGitRef(version)(which baked in a compile-time SHA). The generatedagentics-maintenance.ymlhas been regenerated accordingly.compiler_custom_actions_test.go: UpdatedTestCheckoutActionsFolderDevModeHasRepositoryto assert the${{ github.action_ref }}macro is present. Replaced the three separate SHA/tag version tests with a single table-driven testTestCheckoutActionsFolderDevModeAlwaysEmitsCheckoutthat confirms the checkout step and the runtime macro are always emitted regardless of the compiler version string.Behaviour summary
refvalue"dev"${{ github.action_ref }}"v1.2.3"${{ github.action_ref }}"e284d1e"${{ github.action_ref }}"v1.2.3-60-ge284d1e"${{ github.action_ref }}Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.
✨ PR Review Safe Output Test - Run 23050937333