Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_performance] Fix incorrect setting of Trace & HttpMetric attributes #1277

Merged
bparrishMines merged 2 commits into from
Feb 28, 2019
Merged

[firebase_performance] Fix incorrect setting of Trace & HttpMetric attributes #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b369c98
Fix Perf Attributes
Salakar Feb 24, 2019
3721012
Update AUTHORS
Salakar Feb 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ Diego Velásquez <diego.velasquez.lopez@gmail.com>
Hajime Nakamura <nkmrhj@gmail.com>
Tuyển Vũ Xuân <netsoft1985@gmail.com>
Sarthak Verma <sarthak@artiosys.com>
Mike Diarmid <mike@invertase.io>
Invertase <oss@invertase.io>
4 changes: 2 additions & 2 deletions packages/firebase_performance/ios/Classes/FirebasePerformancePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ - (void)handleTraceStop:(FlutterMethodCall *)call result:(FlutterResult)result {

NSDictionary *attributes = call.arguments[@"attributes"];
[attributes enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *value, BOOL *stop) {
[trace setValue:key forAttribute:value];
[trace setValue:value forAttribute:key];
}];

[trace stop];
Expand Down Expand Up @@ -149,7 +149,7 @@ - (void)handleHttpMetricStop:(FlutterMethodCall *)call result:(FlutterResult)res

NSDictionary *attributes = call.arguments[@"attributes"];
[attributes enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *value, BOOL *stop) {
[metric setValue:key forAttribute:value];
[metric setValue:value forAttribute:key];
}];

[metric stop];
Expand Down