This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_performance] Fix incorrect setting of Trace & HttpMetric attributes#1277
Merged
bparrishMines merged 2 commits intoflutter:masterfrom Feb 28, 2019
invertase:@salakar/bugfix/perf
Merged
[firebase_performance] Fix incorrect setting of Trace & HttpMetric attributes#1277bparrishMines merged 2 commits intoflutter:masterfrom invertase:@salakar/bugfix/perf
bparrishMines merged 2 commits intoflutter:masterfrom
invertase:@salakar/bugfix/perf
Conversation
bparrishMines
approved these changes
Feb 28, 2019
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the contribution! I'll submit the other PR (#1278) when it's tests are finished.
romaluca
pushed a commit
to romaluca/plugins
that referenced
this pull request
Mar 6, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The args for trace and metric attributes are the wrong way around, attribute value is where the key should be and vice-versa. This PR swaps them around for both.
iOS
FIRPerformanceAttributabledefinitionChangelog
TracesandHttpMetricswere incorrectly using the attribute value as the attributes' name.