Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Cast the NSInteger to long and use %ld formatter #1250

Merged
mehmetf merged 2 commits into from
Feb 22, 2019
Merged

[video_player] Cast the NSInteger to long and use %ld formatter #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fba160
Cast the NSInteger to long and use %ld formatter
mehmetf Feb 21, 2019
69e004b
Fix formatting.
mehmetf Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/video_player/ios/Classes/VideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ - (CGAffineTransform)fixTransform:(AVAssetTrack*)videoTrack {
// displays the video https://github.com/flutter/flutter/issues/17606#issuecomment-413473181
if (transform.tx == 0 && transform.ty == 0) {
NSInteger rotationDegrees = (NSInteger)round(radiansToDegrees(atan2(transform.b, transform.a)));
NSLog(@"TX and TY are 0. Rotation: %d. Natural width,height: %f, %f", rotationDegrees,
NSLog(@"TX and TY are 0. Rotation: %ld. Natural width,height: %f, %f", (long)rotationDegrees,
videoTrack.naturalSize.width, videoTrack.naturalSize.height);
if (rotationDegrees == 90) {
NSLog(@"Setting transform tx");
Expand Down Expand Up @@ -185,8 +185,6 @@ - (instancetype)initWithPlayerItem:(AVPlayerItem*)item frameUpdater:(FLTFrameUpd
if (_disposed) return;
if ([videoTrack statusOfValueForKey:@"preferredTransform"
error:nil] == AVKeyValueStatusLoaded) {
CGSize size = videoTrack.naturalSize;

// Rotate the video by using a videoComposition and the preferredTransform
_preferredTransform = [self fixTransform:videoTrack];
// Note:
Expand All @@ -209,8 +207,6 @@ - (instancetype)initWithPlayerItem:(AVPlayerItem*)item frameUpdater:(FLTFrameUpd
_player = [AVPlayer playerWithPlayerItem:item];
_player.actionAtItemEnd = AVPlayerActionAtItemEndNone;

CGSize size = item.presentationSize;

[self createVideoOutputAndDisplayLink:frameUpdater];

[self addObservers:item];
Expand Down