Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Cast the NSInteger to long and use %ld formatter#1250

Merged
mehmetf merged 2 commits intomasterfrom
b22
Feb 22, 2019
Merged

[video_player] Cast the NSInteger to long and use %ld formatter#1250
mehmetf merged 2 commits intomasterfrom
b22

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Feb 21, 2019

This avoids platform dependent compilations errors and is the official recommendation by Apple: https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html

Also remove a couple of unused vars.

This avoids platform dependent compilations errors and is the official recommendation by Apple: https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html

Also remove a couple of unused vars.
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the submit queue The Flutter team is in the process of landing this PR. label Feb 22, 2019
@bparrishMines bparrishMines changed the title Cast the NSInteger to long and use %ld formatter [video_player] Cast the NSInteger to long and use %ld formatter Feb 22, 2019
@mehmetf mehmetf merged commit db0b180 into master Feb 22, 2019
@mehmetf mehmetf deleted the b22 branch February 22, 2019 01:01
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* [cloud_functions] Fix Android package

* [cloud_functions] Bump version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes submit queue The Flutter team is in the process of landing this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants