[camera] Camera with MediaSettings: platform implementations (federated) by PROGrand · Pull Request #5223 · flutter/packages

PROGrand · 2023-10-24T19:51:01Z

Platform implementations of federated plugin

This is the platform implementations part of camera PR #3586.

camera_platform_interface: 2.6.0 merged and published in PR #3615.

Now repeating steps 3,4 (see Changing federated plugins), because camera/camera depends on implementations camera/camera_android, camera/camera_web etc.

MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

PROGrand · 2024-01-31T23:58:31Z

@stuartmorgan
Hello, i applied all suggestions. Including your ones for camera_windows. @ditman approved camera_web.

stuartmorgan-g

Windows mostly looks good; I did a pass of the Obj-C after some of it caught my attention while skimming the other implementations, and I left a number of comments there.

packages/camera/camera_android/example/pubspec.yaml

packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.m

packages/camera/camera_avfoundation/ios/Classes/CameraPlugin.m

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

packages/camera/camera_windows/windows/record_handler.h

jmagman · 2024-02-14T20:41:41Z

@stuartmorgan any more changes requested here? Or is this ready to be merged?

stuartmorgan-g

Thanks for the test structure changes, that looks much safer than all the class mocking.

packages/camera/camera_android_camerax/example/pubspec.yaml

packages/camera/camera_avfoundation/example/pubspec.yaml

packages/camera/camera_web/example/pubspec.yaml

packages/camera/camera_windows/example/pubspec.yaml

packages/camera/camera_avfoundation/ios/Classes/CameraPlugin.m

packages/camera/camera_avfoundation/ios/Classes/FLTCam.h

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

packages/camera/camera_avfoundation/ios/Classes/FLTCam.h

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

jmagman · 2024-03-13T21:15:05Z

@stuartmorgan this is blocked on your review

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettingsAVWrapper.h

packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.m

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

PROGrand · 2024-03-14T19:27:31Z

@stuartmorgan Thank, you for review. Your suggestions are applied.

vashworth · 2024-04-03T20:59:59Z

@stuartmorgan Can you take a look when you have time?

stuartmorgan-g

Sorry for the delay again; just a few last small things.

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

PROGrand · 2024-04-05T11:47:16Z

@stuartmorgan suggestions applied

stuartmorgan-g

LGTM! Could you rebase and squash a few of the commits together to get this under 250 commits, so that the CLA check will pass without intervention?

suggestions applied AssertPositiveNumberOrNil: macro to inline formatted .class to +class Update packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m Co-authored-by: Jenn Magder <magder@google.com> applied suggestions. 02/25/2024. dependency injection (DI) variant for unit test ObjC suggestions applied suggestion applied updated camera_platform_interface versions reverted changes to camera merged 01/07/2024 refactored and co0mmented warning suppressions. renamed MediaRecorderBuilder.RecordingParameters merged 12/07/2023

stuartmorgan-g

A bunch of files showed as changed since review, and because of the squash I can't tell if that's a GitHub artifact of the squash, or actual changes, so I re-reviewed those files. That turned up a few more minor comments which may be things I just didn't previously review, but I've flagged them regardless. Sorry that means one more quick pass.

packages/camera/camera_web/example/pubspec.yaml

packages/camera/camera_windows/example/pubspec.yaml

packages/camera/camera_avfoundation/example/lib/camera_controller.dart

packages/camera/camera_avfoundation/example/lib/main.dart

packages/camera/camera_android_camerax/example/pubspec.yaml

packages/camera/camera_android_camerax/pubspec.yaml

two lines

PROGrand · 2024-04-05T15:29:59Z

@stuartmorgan resolved

stuartmorgan-g

Thanks!

PROGrand and others added 30 commits March 29, 2023 17:46

added MediaSettings

f294625

updated changelog

5ca79b9

MediaSettings introduced.

e08e046

Merge branch 'flutter:main' into main

21617de

excerpts added. formatted.

59d66d3

versions and changelogs

aeec92e

CameraPlatform.createCameraWithSettings

869b787

Merge branch 'main' into main

3cf6030

Merge branch 'flutter:main' into main

6ac763e

Update CHANGELOG.md

a40177a

Update camera_test.dart

fea1fc7

MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).

Update main.dart

9f71f8d

MediaSettings.low removed

4a0ac77

media settings low

8fcf1ae

merger mediasettings

da4ecd8

resolved multiple @hellohuanlin зкщзÑproposals

16645ef

fps control

d7dea54

Fixed pausing preview on already paused or closed session.

6caea7e

Prevent pausing preview on uninitialized controller.

4bec8f3

Prevent pausing preview on disposed controller.

11b43c1

Merge branch 'flutter:main' into main

772e011

formatted

dbb752d

Merge branch 'main' into main

7f01b93

Update packages/camera/camera_android/CHANGELOG.md

3506af1

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

Update packages/camera/camera/CHANGELOG.md

8f95dc2

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

bump gradle:7.20 in CHANGELOG

6b1f96c

commented feature properties

6f97b51

android_camera_camerax CHANGELOD update

d96f9d5

revert default enableAudio to false

401adce

properly commented IntFeature

8edd212

github-actions bot added p: flutter_image p: rfw Remote Flutter Widgets p: go_router p: animations p: dynamic_layouts The dynamic_layouts package p: flutter_adaptive_scaffold p: espresso p: file_selector p: flutter_plugin_android_lifecycle labels Jan 30, 2024

stuartmorgan-g requested changes Feb 1, 2024

View reviewed changes

stuartmorgan-g requested changes Feb 20, 2024

View reviewed changes

jmagman reviewed Mar 6, 2024

View reviewed changes

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m Outdated Show resolved Hide resolved

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m Outdated Show resolved Hide resolved

jmagman approved these changes Mar 13, 2024

View reviewed changes

stuartmorgan-g requested changes Mar 14, 2024

View reviewed changes

stuartmorgan-g requested changes Apr 4, 2024

View reviewed changes

stuartmorgan-g approved these changes Apr 5, 2024

View reviewed changes

PROGrand and others added 3 commits April 5, 2024 17:13

Merge branch 'main' into camera-with-settings-platform-implementations

864b2e1

rebased, squashed, merged

30837eb

stuartmorgan-g requested changes Apr 5, 2024

View reviewed changes

suggestions applied

8b29fa0

two lines

stuartmorgan-g approved these changes Apr 5, 2024

View reviewed changes

engine-flutter-autoroll mentioned this pull request Apr 8, 2024

Roll Packages from 764d9974522b to 6b4d8b6cdb39 (5 revisions) flutter/flutter#146429

Merged

Conversation

PROGrand commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Platform implementations of federated plugin

Uh oh!

PROGrand commented Jan 31, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman commented Feb 14, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman commented Mar 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PROGrand commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vashworth commented Apr 3, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PROGrand commented Apr 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PROGrand commented Apr 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

PROGrand commented Oct 24, 2023 •

edited

Loading

PROGrand commented Mar 14, 2024 •

edited

Loading