[camera] MediaSettings parameter for createCameraWithSettings#3586
Merged
auto-submit[bot] merged 159 commits intoflutter:mainfrom May 6, 2024
Merged
[camera] MediaSettings parameter for createCameraWithSettings#3586auto-submit[bot] merged 159 commits intoflutter:mainfrom
auto-submit[bot] merged 159 commits intoflutter:mainfrom
Conversation
PROGrand
requested review from
bparrishMines,
camsim99,
cbracken,
ditman and
hellohuanlin
as code owners
github-actions
bot
added
p: camera
platform-android
platform-ios
platform-web
platform-windows
labels
Contributor
Author
|
This is main PR. Platform interface's PR is here: #3615 |
Contributor
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
Thanks for the contribution. This is very nice feature to have. Can you share a video capture after this change?
packages/camera/camera/example/integration_test/camera_test.dart
Outdated
Show resolved
Hide resolved
MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).
stuartmorgan-g
requested changes
Apr 17, 2024
packages/camera/camera/README.md
Outdated
| <?code-excerpt "readme_full_example.dart (FullAppExample)"?> | ||
| ```dart | ||
| import 'package:camera/camera.dart'; | ||
| import 'package:camera_platform_interface/camera_platform_interface.dart'; |
Collaborator
There was a problem hiding this comment.
This is still here.
|
|
||
| // #docregion FullAppExample | ||
| import 'package:camera/camera.dart'; | ||
| import 'package:camera_platform_interface/camera_platform_interface.dart'; |
Comment on lines
+237
to
+244
| CameraController( | ||
| CameraDescription description, | ||
| this.resolutionPreset, { | ||
| this.enableAudio = true, | ||
| ResolutionPreset resolutionPreset, { | ||
| bool enableAudio = true, | ||
| this.imageFormatGroup, | ||
| }) : mediaSettings = MediaSettings( | ||
| resolutionPreset: resolutionPreset, enableAudio: enableAudio), | ||
| super(CameraValue.uninitialized(description)); |
Collaborator
There was a problem hiding this comment.
This hasn't been addressed.
Contributor
Author
|
Sorry, what did you mean? |
Collaborator
|
Contributor
Author
|
@stuartmorgan |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for enabling fps and bitrate control of recorded video.
Allow users to more control over recorded video size.
CameraPlatform.createCameraWithSettingsis added, leaving originalCameraPlatform.createCameracommented as deprecated. So this is not breaking change.Tested on a set of mobile devices.
Web support depends on browser (perfect with Firefox).
Fixes flutter/flutter#54339