Skip to content

Conversation

@kenzieschmoll
Copy link
Member

No description provided.

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner July 14, 2025 15:51
@kenzieschmoll kenzieschmoll requested review from elliette and removed request for a team July 14, 2025 15:51
@kenzieschmoll kenzieschmoll requested a review from bkonyi as a code owner July 14, 2025 16:29
@kenzieschmoll
Copy link
Member Author

@incendial the DCM check here seems to be failing with a false positive: https://github.com/flutter/devtools/actions/runs/16272396154/job/45943159382?pr=9310. When I remove this ignore, I get hit with a warning about avoiding dynamic instead.

@incendial
Copy link
Contributor

incendial commented Jul 14, 2025

@incendial the DCM check here seems to be failing with a false positive: https://github.com/flutter/devtools/actions/runs/16272396154/job/45943159382?pr=9310. When I remove this ignore, I get hit with a warning about avoiding dynamic instead.

Do you mean you get a warning locally? If so, then are you on 1.30.0 locally as well?
The rule was updated in 1.30.0 so this warning on CI is correct, this parameter https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/object_store.dart#L48 gets its type implicitly because of the override.

@incendial
Copy link
Contributor

Ah, it seems it is actually dynamic.

@incendial
Copy link
Contributor

incendial commented Jul 14, 2025

I tested it locally with 1.30.0, I don't see a warning when the ignore is removed.
But there are 2 ways to "fix" this without updating the tool:

  1. add explicit dynamic type: dynamic data and keep the ignore.
  2. add a global ignore for avoid-dynamic: // ignore_for_file: avoid-dynamic

@kenzieschmoll kenzieschmoll merged commit bc060b8 into flutter:master Jul 14, 2025
79 of 80 checks passed
@kenzieschmoll kenzieschmoll deleted the dcm branch July 14, 2025 20:06
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants