Skip to content

Support --dtd-exposed-uri in dt tool#9302

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
DanTup:add-exposed-uri-to-dt
Jul 15, 2025
Merged

Support --dtd-exposed-uri in dt tool#9302
auto-submit[bot] merged 1 commit intoflutter:masterfrom
DanTup:add-exposed-uri-to-dt

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Jul 10, 2025

--dtd-exposed-uri is a flag supported by the DevTools server but not in dt serve. This makes it difficult to run DevTools from source in a web based IDE because Dart-Code will pass this flag and the call to dt serve will fail.

@DanTup DanTup requested a review from kenzieschmoll as a code owner July 10, 2025 17:50
@DanTup
Copy link
Contributor Author

DanTup commented Jul 14, 2025

@kenzieschmoll I'm confused by the DCM failure - have you seen this before? It's all code I haven't changed, but it doesn't look like any other PRs or tests on head have failed in this way.

packages/devtools_app/test/screens/deep_link_validation/deep_links_screen_test.dart (1 issue):
WARNING   This ignore does not suppress any diagnostic. Consider removing it.
          at packages/devtools_app/test/screens/deep_link_validation/deep_links_screen_test.dart:39:14
          avoid-unused-ignores : https://dcm.dev/docs/rules/


packages/devtools_app/test/screens/deep_link_validation/select_project_view_test.dart (1 issue):
WARNING   This ignore does not suppress any diagnostic. Consider removing it.
          at packages/devtools_app/test/screens/deep_link_validation/select_project_view_test.dart:22:14
          avoid-unused-ignores : https://dcm.dev/docs/rules/


packages/devtools_app/test/standalone_ui/vs_code/devtools_test.dart (1 issue):
WARNING   This ignore does not suppress any diagnostic. Consider removing it.
          at packages/devtools_app/test/standalone_ui/vs_code/devtools_test.dart:33:14
          avoid-unused-ignores : https://dcm.dev/docs/rules/

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Jul 14, 2025

Those failures are odd considering there aren't any ignores in those files CC @incendial

I opened #9310 to upgrade to DCM 1.30.0. We'll see if checks pass there.

@incendial
Copy link
Contributor

It's all code I haven't changed, but it doesn't look like any other PRs or tests on head have failed in this way.

This is really odd, but it seems that other PR with 1.30.0 shows correct failures.

@DanTup
Copy link
Contributor Author

DanTup commented Jul 14, 2025

Yeah, there's one ignore warning but that line does have an ignore. Odd. I'll try rebasing this one after that lands so it re-runs on the new version.

@DanTup DanTup force-pushed the add-exposed-uri-to-dt branch from 182565e to f074f8b Compare July 15, 2025 08:47
@DanTup DanTup added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2025
@auto-submit auto-submit bot merged commit 1be93f6 into flutter:master Jul 15, 2025
42 checks passed
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
`--dtd-exposed-uri` is a flag supported by the DevTools server but not in `dt serve`. This makes it difficult to run DevTools from source in a web based IDE because Dart-Code will pass this flag and the call to `dt serve` will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants