Remove unreliable packagingOptions.pickFirst for libc++_shared.so and libjsc.so#24672
Closed
Kudo wants to merge 1 commit intofacebook:masterfrom
Closed
Remove unreliable packagingOptions.pickFirst for libc++_shared.so and libjsc.so#24672Kudo wants to merge 1 commit intofacebook:masterfrom
Kudo wants to merge 1 commit intofacebook:masterfrom
Conversation
… libjsc.so. Summary: packagingOptions.pickFirst is unreliable that we could not specify which library will be choosed. If user have other third party libraries, the story is more complicated. From the framework point of view, it is better to drop the pickFirst. In jsc-android 241213.1.0, we did two things: 1. Remove libc++_shared.so in AAR to prevent the conflict with RN. 2. Build by NDK r17c, which aligned with current RN NDK version. In this commit, I also revert the pickFirst for JSC. pickFirst JSC also makes upgrade JSC unreliable. Currently a lot of user report JSC crash issues, those crash issues may relate to JIT and hard to reproduce in-house. My plan is to make sure user could choose another JSC build easier, I.e. only to `yarn add 'jsc-android@latest'`. We could then propose some experimented JSC build for user to check if the build could help them to fix the crash issue.
facebook-github-bot
added
CLA Signed
Contributor
Author
cpojer
approved these changes
May 1, 2019
Contributor
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
@Salakar told me he is on board with this change.
cc @willholen since he is working on some gradle related changes at the moment as well.
facebook-github-bot
approved these changes
May 1, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Salakar
approved these changes
May 1, 2019
Collaborator
|
This pull request was successfully merged by @Kudo in 509a07b. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packagingOptions.pickFirst is unreliable that we could not specify which library will be used.
If user have other third party libraries, the story is more complicated.
From the framework point of view, it is better to drop the pickFirst.
In jsc-android 241213.1.0, we did two things:
In this commit, I also revert the pickFirst for JSC.
pickFirst JSC also makes upgrade JSC unreliable.
Currently a lot of user report JSC crash issues, those crash issues may relate to JIT and hard to reproduce in-house.
My plan is to make sure user could choose another JSC build easier,
i.e. only to
yarn add 'jsc-android@latest'.We could then propose some experimented JSC build for user to check
if the build could help them to fix the crash issue.
Changelog
[Android] [Fixed] - Remove unreliable packagingOptions.pickFirst for libc++_shared.so and libjsc.so
NOTE that this may not need to add the changelog, as RN 0.59 does not have pickFirst.
This will also reduce a breaking change for upgrade from RN 0.59 or before.
Test Plan