[template] add jsc pickFirst packagingOptions#24535
[template] add jsc pickFirst packagingOptions#24535Salakar wants to merge 1 commit intofacebook:masterfrom
Conversation
|
@Salakar I am sorry to introduce this issue. |
|
Hey @Kudo - this was just a fresh RN init of the template currently on 0.60-stable branch (no extra changes made) - there was also nothing extra after the screenshot sorry. I guess the only difference is that it points to the 0.59.5 RN release Reproducible example from the template is here: https://github.com/invertase/react-native-auto-link-example (a single |
|
@Salakar Yes, the problem may related to 0.59.5 release. |
|
@Kudo I agree that this is most likely down to 0.59.5 as well. Maybe it's still worth merging this though, in case anyone downgrades their template for whatever reason (it happens)? |
|
@Salakar IMHO, pickFirst is not reliable to choose correct JSC. In fact, we are trying to remove the pickFirst for libc++_shared.so as well. |
cpojer
left a comment
There was a problem hiding this comment.
I'm gonna land this because it prevents a painful issue for some people in certain situations but I agree we should get rid of the pickFirst stuff altogether.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Kudo that's fair, how would you recommend we remove pickFirst behaviour as I can do another PR for this |
|
This pull request was successfully merged by @Salakar in 7ac1d18. When will my fix make it into a release? | Upcoming Releases |
|
@Salakar I still waiting for the PR which exclude libc++_shared.so being merged and release a new version to npm. |
Summary
Fixes the following build failures on Android Studio (happening when using the 0.60 template):
cc @dulmandakh
Changelog
[Android] [Fixed] - Fixed a
more than one file was found... lib/x86/libjsc.sobuild failure with the templateTest Plan
Build is now successful and the app starts with this change: