Skip to content

WIP try rajasegar/ember-cli-update-codemods-manifest/ember-angle-brackets-codemod #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kellyselden wants to merge 1 commit into from
Closed

WIP try rajasegar/ember-cli-update-codemods-manifest/ember-angle-brackets-codemod #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ All blueprints are up-to-date!`;
statsOnly,
listCodemods,
runCodemods,
codemodsUrl: 'https://raw.githubusercontent.com/ember-cli/ember-cli-update-codemods-manifest/v3/manifest.json',
codemodsUrl: 'https://raw.githubusercontent.com/rajasegar/ember-cli-update-codemods-manifest/ember-angle-brackets-codemod/manifest.json',
createCustomDiff,
ignoredFiles: [await getBlueprintFilePath(cwd)],
wasRunAsExecutable
Expand Down
4 changes: 3 additions & 1 deletion test/fixtures/codemod/latest-node/my-app/app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
<WelcomePage />
{{!-- Feel free to remove this! --}}

{{outlet}}
{{outlet}}
Copy link
Member

@rwjblue rwjblue Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a newline both just before and just after {{outlet}} (based on the input template in test/fixtures/codemod/local/my-app/app/templates/application.hbs)

Copy link
Member Author

@kellyselden kellyselden Nov 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were remnants from when the codemod did a lot more formatting, and the expected was altered to match. This has been reverted now.


<Ui::Button @text="Click me" />
Empty file added test/fixtures/codemod/latest-node/my-app/codemods.log
View file
Open in desktop
Empty file.
4 changes: 3 additions & 1 deletion test/fixtures/codemod/local/my-app/app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
<WelcomePage />
{{!-- Feel free to remove this! --}}

{{outlet}}
{{outlet}}

{{ui/button text="Click me"}}
4 changes: 3 additions & 1 deletion test/fixtures/codemod/min-node/my-app/app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
<WelcomePage />
{{!-- Feel free to remove this! --}}

{{outlet}}
{{outlet}}

<Ui::Button @text="Click me" />
Empty file added test/fixtures/codemod/min-node/my-app/codemods.log
View file
Open in desktop
Empty file.