WIP try rajasegar/ember-cli-update-codemods-manifest/ember-angle-brackets-codemod

[kellyselden]

test ember-cli/ember-cli-update-codemods-manifest#16

[kellyselden]

ember-codemods/ember-angle-brackets-codemod#160

[kellyselden]

      + expected - actual

           "styles": {
             "app.css": ""
           }
           "templates": {
      -      "application.hbs": "{{!-- The following component displays Ember's default welcome message. --}}\r\n<WelcomePage />\r\n{{!-- Feel free to remove this! --}}\r\n\r\n{{outlet}}\r\n\r\n<Ui::Button @text=\"Click me\" />"
      +      "application.hbs": "{{! The following component displays Ember's default welcome message. }}\r\n<WelcomePage />\r\n{{! Feel free to remove this! }}\r\n{{outlet}}\r\n<Ui::Button @text=\"Click me\" />"
             "components": {
               ".gitkeep": ""
             }
           }

[rwjblue]

@kellyselden - I actually think this PR has the expected wrong, in that last diff you pasted just above it shows that the line endings are fine (AFAICT).

[rwjblue]

Why are the -- removed here? The original (assuming that test/fixtures/codemod/local/my-app/app/templates/application.hbs represents the input) uses {{!--, so I would expect the output to continue to use them.

[kellyselden]

These were remnants from when the codemod did a lot more formatting, and the expected was altered to match. This has been reverted now.

[rwjblue]

There should be a newline both just before and just after {{outlet}} (based on the input template in test/fixtures/codemod/local/my-app/app/templates/application.hbs)

[kellyselden]

These were remnants from when the codemod did a lot more formatting, and the expected was altered to match. This has been reverted now.

[kellyselden]

Moved to ember-cli/ember-cli-update-codemods-manifest#16

[kellyselden]

Line endings used to be a problem, but aren't anymore. Thanks to everyone involved!