This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Merged
Conversation
Contributor
|
With this change here https://github.com/code-dot-org/blockly/blob/master/core/ui/fields/field_variable.js#L156 we will still call |
Bjvanminnen
approved these changes
Nov 15, 2018
Contributor
Bjvanminnen
left a comment
Bjvanminnen
left a comment
There was a problem hiding this comment.
Looks good. Having this check in renameVariable makes sense to me. Thanks for picking this up!
| assertEquals("Cannot rename var to empty", 'z', Blockly.Variables.allVariables()[0]); | ||
|
|
||
| goog.dom.removeNode(container); | ||
| } |
Contributor
Author
|
Ah good catch, fixing the |
`Blockly.Variables.renameVariable(newVar, newVar, ...)` is a no-op because of line https://github.com/code-dot-org/blockly/blob/d7e2a4a0f9038511bc7d4dfe4eea7a733ad2f09e/core/utils/variables.js#L131-L133.
islemaster
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Nov 16, 2018
Picks up code-dot-org/blockly#157 which is essential for this change, as well as code-dot-org/blockly#156 which we wanted to ship anyway, and code-dot-org/blockly#152 from a contributor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With guidance from @Bjvanminnen, alternate fix for PR code-dot-org/code-dot-org#26085.