Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Code generation fix for unknown blocks#152

Merged
joshlory merged 1 commit intocode-dot-org:masterfrom
DuncanKeith:unknown-block
Nov 15, 2018
Merged

Code generation fix for unknown blocks#152
joshlory merged 1 commit intocode-dot-org:masterfrom
DuncanKeith:unknown-block

Conversation

@DuncanKeith
Copy link
Contributor

This fixes issue #142. I submitted the contributor license agreement mentioned on this page.

I got some help from @balderdash.

@balderdash balderdash requested a review from joshlory October 5, 2018 21:52
Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test coverage!

@joshlory joshlory merged commit d7e2a4a into code-dot-org:master Nov 15, 2018
islemaster added a commit to code-dot-org/code-dot-org that referenced this pull request Nov 16, 2018
Picks up code-dot-org/blockly#157 which is essential for this change, as well as code-dot-org/blockly#156 which we wanted to ship anyway, and code-dot-org/blockly#152 from a contributor.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants