Merged
Conversation
Updating from BBC repo
removing functions to save and adding callback at parent component
added 4 commits
October 4, 2019 12:38
only works with laodDemo, other import from computer etc.. still not addressed
…nscript-editor into fix-200-component-save
emettely
reviewed
Oct 4, 2019
Contributor
emettely
left a comment
There was a problem hiding this comment.
Looks good - thanks for updating the docs + demos also. If I understood correctly, the AutoSaveChanges is what gives the file extension? Not so sure if the autoSaveFormat is an option that you would want to be able to configure.
Anyways, I have one code suggestion (see below).
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
#200
Describe what the PR does
Option 1 in #200 (comment)
Adds the following attributes to
TranscriptEditorhandleAutoSaveChangeshandleAutoSaveChanges,falls back onsttJsonType. ordraftjsfileNameis no longer used as key to store and retrieve from local storage, but is still in use when exporting transcript in various formats. and it's still optional.onChangeto auto save inTimedTextEditorwas trigger a bit too often, as it was not inside the check to see if the content of draftJs had changed (this.state.editorState.getCurrentContent() !== editorState.getCurrentContent()) so moved it to only be triggered if content has been modified (inserted, deleted etc..)TranscriptEditorstorybook (http://localhost:6006/?path=/story/transcripteditor--default)setStateis async so changed the logic to use result ofupdateTimestampsForEditorStatewhen returning data for autoSave.local-storage.jsunder the demo app, consider whether it's work, in a separate PR, showcase how local storage save would work in the demo app etc.. I'd say low priority tho?State whether the PR is ready for review or whether it needs extra work
Ready for review
Additional context
related Issue
#176
PRs
#177
#199
Once this PR is merged it be good to