Added parameter for hiding save button, straight property pass-through#177
Closed
murezzda wants to merge 1 commit intobbc:masterfrom
Closed
Added parameter for hiding save button, straight property pass-through#177murezzda wants to merge 1 commit intobbc:masterfrom
murezzda wants to merge 1 commit intobbc:masterfrom
Conversation
Contributor
|
still need to discuss this with @jamesdools
|
Contributor
|
Agreed, @pietrop - I think it's a question on whether we do this (toggling the rendering on/off) or being able to map the save function to a customisable thing. Also yes, if it is not rendering but still autosaving, will that cause problems when it tries to read from local storage as you boot it up. Sidenote: as per the PR on optimising re-renders (#175), trying to move creating new elements out of the render block. Will pick this up soon - we have a similar problem on multiple save buttons when integrating this with larger applications. |
This was referenced Oct 3, 2019
Merged
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
This PR references #176.
Describe what the PR does
The
TranscriptEditortag has a new parametershowSaveButton. This is a boolean which is passed down toPlayerControls, where it hides or shows the save button.State whether the PR is ready for review or whether it needs extra work
This is a example PR for this Problem which is very simple. If there is interest of developing such a feature to a greater extend, it would be better to use a more structured approach like a configuration file instead of passing down multiple parameters for each individual component.