Update example hook schema to target real resource types#884
Merged
Brianwithay21 merged 1 commit intoaws-cloudformation:masterfrom May 26, 2022
Merged
Conversation
This was referenced May 17, 2022
Brianwithay21
requested review from
akshayrane,
razcloud,
shri-tambe and
wkexiang
|
Can you fix contracts? |
Member
Author
The contract tests fail because when ruinning This is because the CI Workflow for this retrieves the credentials for the workflow from some credentials file that either does not exist or I dont have access to. Either way most PRs fail this contract test WF and I assume that is the reason it is not required |
shri-tambe
approved these changes
May 20, 2022
Brianwithay21
force-pushed
the
init-real-targets
branch
from
1e6b4db to
fad41e4
Compare
wkexiang
approved these changes
May 25, 2022
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the example hook schema to target an
AWS::S3::Bucketto provide a real world example after initiating a hook projectRelated PRs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.