Updated initial hook example boilerplate code to target real resource type#398
Merged
Brianwithay21 merged 1 commit intoaws-cloudformation:masterfrom May 26, 2022
Merged
Conversation
Brianwithay21
force-pushed
the
init-real-targets
branch
from
30fbd5e to
4fa3e6b
Compare
Brianwithay21
requested review from
akshayrane,
razcloud,
shri-tambe and
wkexiang
shri-tambe
approved these changes
May 20, 2022
| } | ||
|
|
||
| @Test | ||
| public void handleRequest_nonCompliant() { |
wkexiang
reviewed
May 25, 2022
wkexiang
left a comment
wkexiang
left a comment
There was a problem hiding this comment.
Just want to confirm that those handlers should do the things as expected right? Have you performed any end-to-end tests?
Member
Author
Yes, I built and registered the default boilerplate code and created a complaint stack and non-compliant stack. Both operations had the expected result |
wkexiang
approved these changes
May 26, 2022
Got it. Thanks for confirming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the initial
guided-awsboilerplate code to use a real world example of verifying an S3 bucket's encryptionRelated PR:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.