ui: fix migrate host form no host popup #3682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Kumar <[email protected]>
Contributor
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-353 |
Contributor
|
LGTM Tested manually. No need for any kind of test suite. |
GabrielBrascher
approved these changes
Nov 14, 2019
Member
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Makes sense removing that message.
Code LGTM.
yadvr
approved these changes
Nov 14, 2019
Member
|
This can be merged if someone can manually QA/test to confirm. cc @andrijapanicsb @borisstoyanov |
Contributor
|
I have done that Rohit check my previous comment. |
DaanHoogland
pushed a commit
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Abhishek Kumar <[email protected]>
DaanHoogland
added a commit
that referenced
this pull request
Jan 7, 2020
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes behaviour for VM migrate host form where currently it shows a popup on scrolling to the end of the list saying
No more hosts are available for migration. Popup has been removed to avoid confusion cleaner user experience.Popup,
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
From UI
https://screencast-o-matic.com/watch/cqXIjtUDzF