Increase DHCP lease time to infinite #3662
Merged
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since (RHEL) system lose routes when they receive DHCPNAK When VM is expunged, it's active lease and DHCP/DNS config is properly removed from related files in VR.
andrijapanicsb
requested review from
kiwiflyer,
nvazquez,
rafaelweingartner,
wido and
yadvr
andrijapanicsb
changed the title
Contributor
Author
|
CC @ustcweizhou (your username/name does NOT appear when requesting review...) |
andrijapanicsb
requested review from
GabrielBrascher and
PaulAngus
and removed request for
rafaelweingartner
Contributor
Author
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-336 |
Contributor
Author
|
@blueorangutan test |
|
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-444)
|
weizhouapache
approved these changes
Nov 4, 2019
DaanHoogland
pushed a commit
that referenced
this pull request
Jan 3, 2020
* Increase lease time to infinite Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since (RHEL) system lose routes when they receive DHCPNAK When VM is expunged, it's active lease and DHCP/DNS config is properly removed from related files in VR. * desc fix
DaanHoogland
added a commit
that referenced
this pull request
Jan 7, 2020
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
* Increase lease time to infinite Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since (RHEL) system lose routes when they receive DHCPNAK When VM is expunged, it's active lease and DHCP/DNS config is properly removed from related files in VR. * desc fix
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack.
Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since
(RHEL) system lose routes when they receive DHCPNAK.
When VM is expunged, its active lease and DHCP/DNS config is properly removed (#3627 and #3608) from related files in VR, so the infinite duration of lease does not cause any issues or garbage.
There will be soon a PR which also regenerates the /var/lib/misc/dnsmasq.leases (active lease DB file) in the new VR (when restarting network with cleanup), which will help around RHEL edge cases (described above) for the VMs who are already running in productions systems with 30d lease time.
Types of changes