[EDU-765] CHORES Jwt authentication nodejs fix#104
Merged
fliptopbox merged 3 commits intojwt-authentication-nodejsfrom Aug 8, 2022
Merged
[EDU-765] CHORES Jwt authentication nodejs fix#104fliptopbox merged 3 commits intojwt-authentication-nodejsfrom
fliptopbox merged 3 commits intojwt-authentication-nodejsfrom
Conversation
- repaced old logo with static asset - replaced old UI with ably-ui like form - updated JavaScript to ES6 - Added missing package.json
fliptopbox
force-pushed
the
jwt-authentication-nodejs-fix
branch
from
cef9789 to
d1112e4
Compare
Contributor
Author
|
@marklewin for consistency i added you to review, since you have context of the textile file, that links to this repo. |
marklewin
suggested changes
Aug 2, 2022
Contributor
marklewin
left a comment
marklewin
left a comment
There was a problem hiding this comment.
Much better! Small typo in the UI though.
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see complimentary changes to tutorial (ably/docs#1502)
package.jsonRelated work:
Websitepage Website PRdocstutorial, to use the update screenshot and updated JavaScript docs tutorial PRsource code, and replace out-of-date ably logo. Source code PR