[EDU-765] Update jwt authentication tutorial#1502
Conversation
|
@tbedford & @marklewin this is my very first docs contribution, so i am tending on the side of caution for this PR. |
marklewin
left a comment
There was a problem hiding this comment.
Looks good. Love the fancy new dialog 👏 I've made a few suggestions to help make the instructions a bit clearer and fix a couple of grammar/typo things.
| 4. Navigate your browser to @http://localhost:3000@, since your Express server is listening on port 3000. | ||
|
|
||
| You will see the login form. Open the browser JavaScript console if you want to see the logged messages. | ||
| You will see the login form. Open the browser JavaScript console if you want to see the logged messages. |
There was a problem hiding this comment.
Suggest making the opening of the browser console a step in its own right, otherwise there's not really any point in having the console.log() statements.
850f045 to
a63fb96
Compare
marklewin
left a comment
There was a problem hiding this comment.
Great start. A few typos and rewording suggestions and also for improving the live demo.
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
0ecf59c to
52dde6f
Compare
tbedford
left a comment
There was a problem hiding this comment.
I've run through and tested. LGTM!
Description
As part of the stocktaking of all tutorials (see: https://ably.atlassian.net/browse/EDU-765)
This change repated to the updated tutorial PR ably/tutorials#104
we found inconsistencies, and failing code samples, for the most visited tutorial.
This PR is a QUICK-FIX the following:
clientIdand is redundant, the fix corrects this redundancyRelated work:
Websitepage Website PRdocstutorial, to use the update screenshot and updated JavaScript docs tutorial PRsource code, and replace out-of-date ably logo. Source code PR