Action Reference - PR #2#560
Merged
suearkinunity merged 35 commits intosuearkinunity-DOCATT-5849from Oct 14, 2024
Merged
Conversation
|
Sue Arkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
suearkinunity
commented
Aug 23, 2024
Plus two small edits to other pages
suearkinunity
changed the base branch from
master
to
suearkinunity-DOCATT-5849
My thinking was that a user won't know whether they need a loop or ring selection until they've read the docs. Therefore, those two options need to be directly compared.
Some of those are guesses, but they'll do for now. I'll tidy it up again later. Not sure the Shift feature still exists; asked about it.
JonMUnity
reviewed
Sep 3, 2024
Documentation~/Toggle_X_Ray.md
Outdated
Comment on lines
5
to
10
| <!-- | ||
| Note to reviewers: this is a placeholder; the page itself will be written in a different PR. | ||
|
|
||
| [[From the what's new page: * Added a new [Selection X-Ray](preferences.md#sel-xray) option to highlight hidden element selections with a muted color. The default shortcut is **Ctrl/Alt+Shift+X** (modifiable in the Shortcuts Manager), and you can also access it through the ProBuilder menu (**Tools** > **ProBuilder** > **Interaction** > **Toggle X Ray**).]] | ||
|
|
||
| [[why is this both a preference an an action?]]--> |
Contributor
There was a problem hiding this comment.
I don't really know much about this feature. @modrimkus, can you explain this one?
Contributor
There was a problem hiding this comment.
@suearkinunity It toggles if selected elements that are occluded by geometry are still visualized.
Screen.Recording.2024-09-05.at.10.59.55.AM.mov
For why it's a pref but also has a shortcut - I'm not sure.
suearkinunity
commented
Sep 5, 2024
Documentation~/TableOfContents.md
Outdated
| * [Create and edit Bezier shapes](workflow-create-bezier) | ||
| * [Perform Boolean operations](boolean) | ||
| * [Store meshes as assets](meshes-as-assets) | ||
| * [Bezier Shape tool](workflow-create-bezier) |
Contributor
Author
There was a problem hiding this comment.
I have a feeling I don't want this change. Please don't merge until I've figured it out.
Making it match Msater
But I have some questions
I was using a couple of wrong files. Also, I'm killing the Tools vs Actions page. First of all, we can't keep calling them actions because Actions is a category of Actions, and we can't do that to our poor users. Second, this page duplicates information that's better presented in its own context, such as creating meshes and the so-called actions. The conceptual difference between tool and action is really not something users need to worry themselves with.
Got rid of the inset page, because it's just a way to use Extrude
So I removed it
Tidying table
Actions ref PR 5
Undoing changes in the MAT files
Contributor
Author
|
Merging into my working branch (so not into master - nobody panic). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
More work on the Actions Reference pages.
This one took ages because while it covers very few pages, one of those is the landing page.
So we have here:
Spoiler alert: The next few PRs will be based on the new order of the pages in the landing page.
Links
Jira: DOCATT-5849
Comments to Reviewers
See the Purpose of this PR section.