Merged
Conversation
My thinking was that a user won't know whether they need a loop or ring selection until they've read the docs. Therefore, those two options need to be directly compared.
|
Sue Arkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
JonMUnity
approved these changes
Sep 3, 2024
Contributor
Author
|
Merging into my other PR, not Master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Some more work on the Actions Reference. This time it's mostly local to the Selection stuff. The biggest change is in combining the Loop and Ring selection options, so they're more easily compared. The thinking is that a user doesn't know which one to use until they've read the docs, so those should be together to make things clearer and reduce clicking around.
Links
Jira: DOCATT-5849
Comments to Reviewers
Still a draft.