Remove support for deprecated plugins

[jkschulz]

Confirmed on CentOS 7 that adding configs for PostgreSQL, MongoDB, Varnish, and ZooKeeper cause the agent to fail to start (expected). The other deprecated applications use generic plugins (Plugin:GenericJMX = Cassandra, HBase, Kafka, Tomcat; Plugin:cURL-JSON = CouchDB, Elasticsearch, RabbitMQ, Riak) so those will still work.
Also confirmed that the non-deprecated 3P applications still work as expected (Apache, JVM, Memcached, MySQL, Nginx, Redis).

[igorpeshansky]

Haven't had a chance to look at the spec changes, but have some comments on the Debian builds.

[jkohen]

So many deleted lines, I like it! Thanks for thoroughly testing the changes on CentOS 7. I see this PR affects files for many other distributions. How did you verify that those continue to work? @jkschulz

[igorpeshansky]

Both the rpm spec and the Debian build files LGTM. Same question as Javier about testing.

[sophieyfang]

It will be tedious for @jkschulz <https://github.com/jkschulz> to test it against all touched distros and remaining third party apps. Can she post the pkg built from her branch so as it will be under a REPO_SUFFIX? Then I can guide her how to test it in my CL and Google Doc Instructions which will do an integration test against all supported distros and third party apps except windows, amazon and StatsD.

…

On Tue, Dec 10, 2019 at 12:00 PM igorpeshansky ***@***.***> wrote: ***@***.**** approved this pull request. Both the rpm spec and the Debian build files LGTM. Same question as Javier about testing. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#83?email_source=notifications&email_token=AB7XXBS6PWQHX6SU4BBJ7ELQX7DJHA5CNFSM4JYTZZ72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOVVJPQ#pullrequestreview-329995454>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7XXBXSQSYJTFZ5OZQO42DQX7DJHANCNFSM4JYTZZ7Q> .

[jkschulz]

With @sophieyfang's help, the 3rd party apps we still support (apache, jvm, memcached, mysql, nginx, redis) were tested and verified on the remaining distros (centos8, ubuntu 18.04 (bionic), ubuntu 16.04 (xenial), debian 9 (stretch), debian 10 (buster), sles 12, and sles 15).

I also ran a script on each of those distros that pulled in sample configs for the 4 non-generic deprecated apps (PostgreSQL, MongoDB, Varnish, and ZooKeeper) and confirmed that the presence of each caused the agent to fail to start as expected.

[jkohen]

Awesome, thank you so much!

…

On Fri, Dec 20, 2019 at 11:48 AM jkschulz ***@***.***> wrote: Merged #83 <#83> into master. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#83?email_source=notifications&email_token=ABWRG2G4HPAZDB2SNGWEBADQZTZMZA5CNFSM4JYTZZ72YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVTXK6HI#event-2901323549>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWRG2G5YFBF5MSZ75C62U3QZTZMZANCNFSM4JYTZZ7Q> .