Update build container Dockerfiles to allow them to build again.#132
Merged
qingling128 merged 3 commits intomasterfrom Jun 27, 2022
Merged
Update build container Dockerfiles to allow them to build again.#132qingling128 merged 3 commits intomasterfrom
qingling128 merged 3 commits intomasterfrom
Conversation
qingling128
approved these changes
Jun 25, 2022
Contributor
qingling128
left a comment
qingling128
left a comment
There was a problem hiding this comment.
LGTM with a question
| RUN zypper addrepo https://download.opensuse.org/repositories/Apache/SLE_12_SP4/Apache.repo \ | ||
| # Add SLES 15 repo to install libhiredis0_13 from hiredis-devel. | ||
| && zypper addrepo https://download.opensuse.org/repositories/server:database/SLE_15/server:database.repo \ | ||
| # Remove expired root certificate. |
igorpeshansky
added a commit
that referenced
this pull request
Jun 27, 2022
Also a cosmetic update to the URL in the amzn build container. A follow-on to #132.
igorpeshansky
commented
Jun 27, 2022
| FROM amazonlinux:2016.09 | ||
|
|
||
| ADD http://ftp.tu-chemnitz.de/pub/linux/dag/redhat/el6/en/x86_64/rpmforge/RPMS/rpm-macros-rpmforge-0-6.el6.rf.noarch.rpm . | ||
| ADD https://rpmfind.net/linux/dag/redhat/el6/en/i386/dag/RPMS/rpm-macros-rpmforge-0-6.el6.rf.noarch.rpm . |
Contributor
Author
There was a problem hiding this comment.
Not that it matters too much (it's a noarch RPM), but I probably should have used x86_64 instead of i386 here… Fixed in #133.
| perl-ExtUtils-Embed \ | ||
| pkgconfig \ | ||
| postgresql-devel \ | ||
| python36-devel \ |
Contributor
Author
There was a problem hiding this comment.
This needed to be updated to python2-devel. Fixed in #133.
igorpeshansky
added a commit
that referenced
this pull request
Jun 27, 2022
Also a cosmetic update to the URL in the amzn build container. A follow-on to #132.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for continuing work on #131.
Also restore some deprecated dependencies. This is part of the effort to switch to
masteras the source of truth for these. The dependencies are harmless, since they are not included unless explicitly enabling the plugins, but allows the legacy builds to proceed. This partially reverts #83 (only the build container part).